[jbosstools-issues] [JBoss JIRA] (JBIDE-3628) Plugins should be .jar's not directories for efficiency sake

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-3628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760858#comment-12760858 ] 

Max Rydahl Andersen commented on JBIDE-3628:
--------------------------------------------

Ah didnt realize the data on this- thanks Rob ;)

Thus I went and looked in our 7 alpha what the state is:

max at slowbeard: $ find . -maxdepth 1 -type d | grep *jboss*                                                                           /Applications/jbdevstudio7alpha1/studio/plugins
grep: org.jboss.ide.eclipse.archives.core_3.4.100.Alpha1-v20130217-1728-B11: Is a directory
grep: org.jboss.ide.eclipse.freemarker_1.3.0.Final-v20130207-2332-B83: Is a directory
grep: org.jboss.tools.common.gef_3.5.0.Alpha1-v20130216-0701-B10: Is a directory
grep: org.jboss.tools.common.model.ui_3.5.0.Alpha1-v20130216-0701-B10: Is a directory
grep: org.jboss.tools.common.model_3.5.0.Alpha1-v20130216-0701-B10: Is a directory
grep: org.jboss.tools.common.projecttemplates_3.5.0.Alpha1-v20130216-0701-B10: Is a directory
grep: org.jboss.tools.forge.runtime.ext_1.2.0.Alpha1-v20130216-0716-B10: Is a directory
grep: org.jboss.tools.forge.runtime_1.2.0.Alpha1-v20130216-0716-B10: Is a directory
grep: org.jboss.tools.hibernate.ui_3.7.0.Alpha1-v20130216-0715-B7: Is a directory
grep: org.jboss.tools.hibernate4_0_3.7.0.Alpha1-v20130216-0715-B7: Is a directory
grep: org.jboss.tools.jsf.vpe.ajax4jsf_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.facelets_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.jbpm_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.jsf_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.jstl_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.myfaces_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.richfaces_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jsf.vpe.seam_3.5.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.jst.web.kb_3.5.0.Alpha1-v20130211-2005-B3: Is a directory
grep: org.jboss.tools.struts.vpe.struts_3.4.0.Alpha1-v20130214-1356-B6: Is a directory
grep: org.jboss.tools.vpe.docbook_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.html_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.jsp_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.resref_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.spring_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.ui.palette_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe.xulrunner_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.vpe_3.5.0.Alpha1-v20130218-1313-B9: Is a directory
grep: org.jboss.tools.xulrunner.initializer_3.5.0.Alpha1-v20130218-1313-B9: Is a directory

Out of these I believe the following has no reason to be exploded:

org.jboss.ide.eclipse.*
org.jboss.tools.common*
org.jboss.tools.jsf.vpe*
org.jboss.tools.struts.*
org.jboss.tools.vpe*

The xulrunner, hibernate and forge are dirs because of the jar library they contain (would have to be unzipped constantly)


                
> Plugins should be .jar's not directories for efficiency sake
> ------------------------------------------------------------
>
>                 Key: JBIDE-3628
>                 URL: https://issues.jboss.org/browse/JBIDE-3628
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: Build/Releng
>            Reporter: Max Rydahl Andersen
>            Assignee: Denis Golovin
>            Priority: Critical
>             Fix For: 4.1.x
>
>         Attachments: exception.log
>
>
> 65 of our plugins are bundled exploded instead of a .jar
> Some are probably just mistakes and can easily be packed others are because of legacy code assuming it can access the files directly and even store data in the plugins - that should be fixed.
> What should be fixed:
> 1. The way how plug-ins use images in plugin.xml, in java code and in .meta xmodel files
> 2. Plug-ins that loads resources should be aware that they are in jar now (VPE should be able to load templates from plugin jar files)
> 3. Some plug-ins contain resources registered in XML catalog
> 4. common.projecttemplates contains resources that is used as template for new projects
> 5. TBD

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira