[jbosstools-issues] [JBoss JIRA] (JBIDE-13799) Source Lookup enhancements

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762378#comment-12762378 ] 

Max Rydahl Andersen commented on JBIDE-13799:
---------------------------------------------

This looks pretty interesting but could we not separate bugfixes from feature implementation:

i.e. this should be separate PR:
AS 7.2/EAP 6.1 are now recognized correctly
the fix for the issue caused by changing the editor ID for ClassFileEdtor in 3.8/4.2
the fix for the ConcurrentModificationException exception

And what does
"included libraries can be filtered - jsf 1.2 and hibernate 3 will be excluded by default for JBoss AS Container" mean ? Doesn't the source container now have knowledge that the AS container should have instead ? 

And this:
"JBoss Runtimes now can be included in the Java Search (this feature has been implemented in a similar way to adding PDE plugins to the Java Search)"

sounds really interesting - but isn't this a separate jira/feature ? What kind of external container is used here ?

"JBoss Java Project Source Container"

This one is also separate feature afacis - the name is not very informative of what it do, nor why this is needed and how it work - i.e. why is the default Maven source container not enough?


                
> Source Lookup enhancements
> --------------------------
>
>                 Key: JBIDE-13799
>                 URL: https://issues.jboss.org/browse/JBIDE-13799
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>
> The PR includes the following enhancements:
> - AS 7.2/EAP 6.1 are now recognized correctly
> - the fix for the issue caused by changing the editor ID for ClassFileEdtor in 3.8/4.2
> - the fix for the ConcurrentModificationException exception
> - included libraries can be filtered - jsf 1.2 and hibernate 3 will be excluded by default for JBoss AS Container 
> - JBoss Runtimes now can be included in the Java Search (this feature has been implemented in a similar way to adding PDE plugins to the Java Search)
> - JBoss Java Project Source Container
> See http://screencast.com/t/39LHqYx5m
> Screenshot shows debugging the WeldBootstrap class in JBoss AS 7.1 and JBoss AS 7.2.
> Note:
> You have to have some deployment on the servers in order the WeldBootstrap class to be created.
> You can add more JBoss servers to the Java Search, but it is the best to use only one at a time because of the performance reason.
> The "Automatically add the JBoss Maven source container to all JBoss AS launch configurations" and "Include the following JBoss Servers in the Java Search" checkboxes aren't related. The first checkbox adds the source container that enables finding a Java source file when debugging, the second enables finding a Java source file using the Java Search (using the "Open type" command, for instance).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira