[jbosstools-issues] [JBoss JIRA] (JBIDE-13837) KB Builder does complete scanning of content of every jar file

Thu Mar 21 20:06:41 EDT 2013

    [ https://issues.jboss.org/browse/JBIDE-13837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762504#comment-12762504 ] 

Viacheslav Kabanovich commented on JBIDE-13837:
-----------------------------------------------

JSF 2 specification in section 10.3.2 Facelet Tag Library mechanism defines facelet taglib discovery as follows:

The run time must support two modes of discovery for Facelet tag library descriptors
1. Via declaration in the web.xml, as specified in Section 11.1.3 “Application Configuration Parameters”
2. Via auto discovery by placing the tag library discriptor file within a jar on the web application classpath, naming the
file so that it ends with “.taglib.xml”, without the quotes, and placing the file in the META-INF directory in the
jar file.

That proves that facelet tag libraries in jsf-impl.jar make a special case. Still, we should support it as jsf-impl-2.1.5.jar and jsf-impl-2.2.0.jar include these files. I think that we may just check that jar file name starts with jsf-impl.

> KB Builder does complete scanning of content of every jar file 
> ---------------------------------------------------------------
>
>                 Key: JBIDE-13837
>                 URL: https://issues.jboss.org/browse/JBIDE-13837
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Viacheslav Kabanovich
>            Assignee: Viacheslav Kabanovich
>             Fix For: 4.1.0.Alpha2
>
>
> Memory problem were reported https://community.jboss.org/message/804026#804026
> At present, KB builder scans for facelet taglibs everywhere in jar files, not only in META-INF folder. That results in complete loading of model objects for jar content, which otherwise would remain unloaded. Once loaded, it is not easy to release them, since objects are shared by projects referencing the same jar.
> Complete scanning was implemented as fix for https://issues.jboss.org/browse/JBIDE-5764 in February 2010.
> JSF implementation jsf-impl-2.0.1.jar contains facelet tag libraries in /com/sun/faces/metadata/taglib.
> However, it is recommended that facelet taglib xml files be packaged into META-INF folder. It seems that jsf-impl-2.0.1.jar is a special case. I suggest that we stop doing complete scanning of all jars and do it only for JSF 2 implementation jar.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira