[jbosstools-issues] [JBoss JIRA] (JBIDE-13821) CI runs tests against minimum instead of maximum

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762792#comment-12762792 ] 

Max Rydahl Andersen commented on JBIDE-13821:
---------------------------------------------

I can see you closed the pullrequest but ignored my comments.

The old property has zero effect so use of it from external scripts are irrelevant so how about just removing it so no doubt/maintanence?

btw. changing this is in maintanence does not sound like a good idea to me since it will make build even less reproducible.
                
> CI runs tests against minimum instead of maximum
> ------------------------------------------------
>
>                 Key: JBIDE-13821
>                 URL: https://issues.jboss.org/browse/JBIDE-13821
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 4.0.x, 4.1.0.Alpha2
>            Reporter: Mickael Istria
>            Assignee: Nick Boldt
>            Priority: Critical
>             Fix For: 4.0.1.Final, 4.1.0.Alpha2
>
>
> As Maven executions set a value for the TARGET_PLATFORM_VERSION value, this property is not overriden by the maximum profile.
> Maven order to set properties is
> # look a -D... to set property, if not found
> # look at active profiles to set property, if not found
> # look at default value of property to set it
> This makes that in mvn execution for tests, the TARGET_PLATFORM_VERSION is set to minimal is CI jobs, whereas with using the -Pmaximun profile, we expect maximum.
> This is a critical issue since it caused hours of confusions to debug on 4.0.x branch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira