[jbosstools-issues] [JBoss JIRA] (JBIDE-13733) Clean up JBossASHandler

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762834#comment-12762834 ] 

Max Rydahl Andersen commented on JBIDE-13733:
---------------------------------------------

About naming, my understanding was that runtimedetection is the only place we will get things named according to if it is an SOA-P, EAP, etc. If that is now done properly by sever getdefaults than that sounds great.

I agree about the code being weird with respect to nested runtimes - not really following why a runtime detector can report if it can exist inside a runtime and then just gets called to detect - that should not be slow since those that know they are being nested can look in specific places very fast (i.e. not slow full recursive scanning)
                
> Clean up JBossASHandler
> -----------------------
>
>                 Key: JBIDE-13733
>                 URL: https://issues.jboss.org/browse/JBIDE-13733
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: JBossAS/Servers
>    Affects Versions: 4.1.0.Alpha1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.1.0.Alpha2
>
>
> JBossASHandler is a pretty messy class with many confusing parts to it. Several things need to be changed. 
> 1) Why are default names for server required in this class? Don't runtime type and server type already do this in getDefaults() when the working copy is created?
> 2) The code to check for nested runtimes is very messy and hard to understand. 
> 3) Why are ESB and Drools added separately? Shouldn't the check for all nested runtimes using all handlers be able to find this itself? It seems drools and esb have their own detectors. So why is this required here?
> 4) The drools runtime seems to be not added to any model at all. It seems to just be returned. Is this only cosmetic? What is the purpose here? The drools detector would be adding this to the drools model, but we do not add it to any model, so what is the purpose? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira