[jbosstools-issues] [JBoss JIRA] (JBIDE-10588) Installing on top of plain Eclipse IDE JBoss Maven Seam Integration plugin breaks Maven integration for WTP

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-10588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763125#comment-12763125 ] 

Fred Bricon commented on JBIDE-10588:
-------------------------------------

Took another look at the issue this morning with the latest dev versions. m2e still can't instantiate SeamProjectConfigurator :
* Plug-in "org.jboss.tools.maven.seam" was unable to instantiate class "org.jboss.tools.maven.seam.configurators.SeamProjectConfigurator"
* java.lang.IllegalArgumentException: Project facet jboss.portlet has not been defined.

So, even though there's no direct code dependency to the portlet plugin, the portlet facet is expected to be loaded during class initialization (see https://github.com/jbosstools/jbosstools-central/blob/master/maven/plugins/org.jboss.tools.maven.seam/src/org/jboss/tools/maven/seam/configurators/SeamProjectConfigurator.java#L110)

Simple fix is to handle the case where portlet is unavailable in the code, i.e. add some null checks here and there.

                
> Installing on top of plain Eclipse IDE JBoss Maven Seam Integration plugin breaks Maven integration for WTP
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-10588
>                 URL: https://issues.jboss.org/browse/JBIDE-10588
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 3.3.0.M5
>         Environment: Eclipse 3.7.1.20110916-0149, m2e 1.0.100.20110804-1717, m2e-wtp 0.14.0.20110928-2045
>            Reporter: Rafal Krzewski
>            Assignee: Fred Bricon
>            Priority: Minor
>             Fix For: 3.3.x
>
>         Attachments: JBIDE-10588-test-setup.p2f
>
>
> After installing istalling JBoss Maven Seam Integration plugin from http://download.jboss.org/jbosstools/updates/development/indigo/ m2e-wtp configurator stopped working. Running Maven > Update Configuration produces to following error on any project that is using war or ejb packaging (ear is OK):
> Project configurator "org.jboss.tools.maven.seam.configurator" is not available. To enable full functionality, install the project configurator and run Maven->Update Project Configuration.
> Additionally, maven-ejb-plugin and maven-war-plugin executions are reported as not covered by by lifecycle configuration.
> I've checked with OSGi host console and org.jboss.tools.maven.seam bundle is deployed:
> osgi> ss org.jboss.tools.maven.seam
> id	State       Bundle
> 774	ACTIVE      org.jboss.tools.maven.seam_1.3.0.v20111209-0524-H40-M5
> The configurator extension is also deployed:
> osgi> pt -v org.eclipse.m2e.core.projectConfigurators
> Extension(s):
> -------------------
> null [from org.jboss.tools.maven.seam]
>    <configurator>
>       id = org.jboss.tools.maven.seam.configurator
>       class = org.jboss.tools.maven.seam.configurators.SeamProjectConfigurator
>       name = Seam
>       secondaryTo = org.maven.ide.eclipse.configuration.wtp.configurator
>    </configurator>
> Alas, the configurator class cannot be instantiated. Eclipse error log contains the following:
> Plug-in "org.jboss.tools.maven.seam" was unable to instantiate class "org.jboss.tools.maven.seam.configurators.SeamProjectConfigurator".
> An exception stack trace is not available.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira