[jbosstools-issues] [JBoss JIRA] (JBIDE-11065) Replace build.xml by a Maven plugin

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-11065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763605#comment-12763605 ] 

Nick Boldt edited comment on JBIDE-11065 at 3/27/13 4:37 PM:
-------------------------------------------------------------

Not sure we need to call the FetchZips for anything other than site/ and soa-site/ (previously called "custom.build" from build.xml). Feels like overkill for the webtools-site/, coretests-site/, and soatests-site/ (we didn't collect them previously for those sites - we only called "basic.build" from build.xml, so your adding it in for those is new). You did not enable it for soa-site/ however. It should be turned on there.

The big reason for not pulling all the zips for the webtools site is that it only depends on Base and Server, yet it's doing this (if I add <version>0.16.0-SNAPSHOT</version> into webtools-site/pom.xml):

{code}
[INFO] --- repository-utils:0.16.0-SNAPSHOT:fetch-zips-for-aggregate (generate-facade) @ org.jboss.tools.site.webtools ---
[INFO] Getting zips and metadata from repo 'http://download.jboss.org/jbosstools/builds/staging/jbosstools-base_master'
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-base_master-Update-SNAPSHOT.zip
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-base_master-Sources-SNAPSHOT.zip
[INFO] Getting zips and metadata from repo 'http://download.jboss.org/jbosstools/builds/staging/jbosstools-birt_master'
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-birt_master-Update-SNAPSHOT.zip
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-birt_master-Sources-SNAPSHOT.zip
[INFO] Getting zips and metadata from repo 'http://download.jboss.org/jbosstools/builds/staging/jbosstools-central_master'
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-central_master-Update-SNAPSHOT.zip
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-central_master-Sources-SNAPSHOT.zip
[INFO] Getting zips and metadata from repo 'http://download.jboss.org/jbosstools/builds/staging/jbosstools-forge_master'
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-forge_master-Update-SNAPSHOT.zip
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-forge_master-Sources-SNAPSHOT.zip
[INFO] Getting zips and metadata from repo 'http://download.jboss.org/jbosstools/builds/staging/jbosstools-hibernate_master'
[INFO]   Got /home/nboldt/eclipse/workspace-jboss/jbosstools-github-master/jbosstools-build-sites/aggregate/webtools-site/zips/all/jbosstools-hibernate_master-Update-SNAPSHOT.zip
{code}


Otherwise the PR looks OK at a first glance, but with the above issues. Need to review the new code in org.jboss.tools.tycho-plugins:repository-utils:0.16.0-SNAPSHOT to verify that the mojo does in fact do everything that the ant script previously did: 

{quote}
-  add.repo.properties :: use org.eclipse.wtp.releng.tools.addRepoProperties to add p2.statsURI and download.stats properties for a list of features
-  remove.uncategorized.category
-  remove.uninstallable (eg., central discovery feature)
-  collect.zips :: look for http://download.jboss.org/jbosstools/builds/staging/<job_name>/logs/zip.list.txt; if found, load file get list of relative path zips to then fetch
-  collect.metadata :: collect metadata (JOB_NAME, BUILD_ID, BUILD_NUMBER, WORKSPACE, HUDSON_SLAVE), zip file names+sizes+md5sums
-  create.results.html :: generate a results.html from a template + a bunch of variables, which links to test results, metadata, target platforms. Page is then copied into build folder when publish.sh runs from a job w/ .aggregate in the name
{quote}

                
      was (Author: nickboldt):
    Not sure we need to call the FetchZips for anything other than site/ and soa-site/ (previously called "custom.build" from build.xml). Feels like overkill for the webtools-site/, coretests-site/, and soatests-site/ (we didn't collect them previously for those sites - we only called "basic.build" from build.xml, so your adding it in for those is new). You did not enable it for soa-site/ however. It should be turned on there.

Otherwise the PR looks OK at a first glance, but with the above issues. Need to review the new code in org.jboss.tools.tycho-plugins:repository-utils:0.16.0-SNAPSHOT to verify that the mojo does in fact do everything that the ant script previously did: 

{quote}
-  add.repo.properties :: use org.eclipse.wtp.releng.tools.addRepoProperties to add p2.statsURI and download.stats properties for a list of features
-  remove.uncategorized.category
-  remove.uninstallable (eg., central discovery feature)
-  collect.zips :: look for http://download.jboss.org/jbosstools/builds/staging/<job_name>/logs/zip.list.txt; if found, load file get list of relative path zips to then fetch
-  collect.metadata :: collect metadata (JOB_NAME, BUILD_ID, BUILD_NUMBER, WORKSPACE, HUDSON_SLAVE), zip file names+sizes+md5sums
-  create.results.html :: generate a results.html from a template + a bunch of variables, which links to test results, metadata, target platforms. Page is then copied into build folder when publish.sh runs from a job w/ .aggregate in the name
{quote}

                  
> Replace build.xml by a Maven plugin
> -----------------------------------
>
>                 Key: JBIDE-11065
>                 URL: https://issues.jboss.org/browse/JBIDE-11065
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: Build/Releng
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>            Priority: Minor
>             Fix For: 4.1.0.Alpha2
>
>         Attachments: jbide11065-screenshot-fixed-version.png, jbide11065.png
>
>
> In order to improve the build infrastructure and make it easier to share and consumes with all components, we should replace build.xml by a Maven plugin and make it available througn Nexus. It should follow the parent pom versioning.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira