[jbosstools-issues] [JBoss JIRA] (JBIDE-13812) openshift-java-client: get rid of external class to (de)code base64
RH Bugzilla Integration (JIRA)
jira-events at lists.jboss.org
Thu Mar 28 13:03:41 EDT 2013
[ https://issues.jboss.org/browse/JBIDE-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12763819#comment-12763819 ]
RH Bugzilla Integration commented on JBIDE-13812:
-------------------------------------------------
Tomas Radej <tradej at redhat.com> made a comment on [bug 902017|https://bugzilla.redhat.com/show_bug.cgi?id=902017]
Package Review
==============
Key:
[x] = Pass
[!] = Fail
[-] = Not applicable
[?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
[!]: Changelog in prescribed format.
>>>> There must either be a space on both sides of the delimiting dash, or
>>>> no delimiting dash at all. I. e.
>>>> ...t.org> - 2.0.3-2
>>>> or
>>>> ...t.org> 2.0.3-2
[!]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
>>>> you should include
>>>> %doc license epl-v10.html
>>>> in %files and %files javadoc
Notes:
======
[!]: Requires correct, justified where necessary.
>>>> You don't need to specify Requires when building with %mvn_build
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: Package contains no bundled libraries without FPC exception.
[!]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package requires other packages for directories it uses.
[x]: Package uses nothing in %doc for runtime.
[x]: Package is not known to require ExcludeArch.
[!]: Package complies to the Packaging Guidelines
[!]: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s)
for the package is included in %doc.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses found:
"Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
Detailed output of licensecheck in /home/tradej/reviews/openshift-java-
client/review-openshift-java-client/licensecheck.txt
[x]: Package consistently uses macro is (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[!]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Fully versioned dependency in subpackages, if present.
[x]: Spec file lacks Packager, Vendor, PreReq tags.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage.
Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local
[x]: Package successfully compiles and builds into binary rpms on at least one
supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
Java:
[x]: Fully versioned dependency in subpackages, if present.
[x]: Bundled jar/class files should be removed before build
Maven:
[x]: If package contains pom.xml files install it (including depmaps) even
when building with ant
[x]: Old add_to_maven_depmap macro is not being used
[x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage-
utils for %update_maven_depmap macro
[x]: Package DOES NOT use %update_maven_depmap in %post/%postun
[x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: Dist tag is present.
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define.
Java:
[x]: Package has BuildArch: noarch (if possible)
[x]: Package uses upstream build method (ant/maven/etc.)
===== EXTRA items =====
Generic:
[x]: Large data in /usr/share should live in a noarch subpackage if package is
arched.
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: openshift-java-client-2.0.3-2.20130320git7073708.fc20.noarch.rpm
openshift-java-client.noarch: W: spelling-error %description -l en_US rhc -> rec, rho, Rh
openshift-java-client.noarch: W: incoherent-version-in-changelog -2.0.3-2 ['2.0.3-2.20130320git7073708.fc20', '2.0.3-2.20130320git7073708']
openshift-java-client.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
# rpmlint openshift-java-client
openshift-java-client.noarch: W: spelling-error %description -l en_US rhc -> rec, rho, Rh
openshift-java-client.noarch: W: incoherent-version-in-changelog -2.0.3-2 ['2.0.3-2.20130320git7073708.fc20', '2.0.3-2.20130320git7073708']
openshift-java-client.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
# echo 'rpmlint-done:'
Requires
--------
openshift-java-client (rpmlib, GLIBC filtered):
java
jpackage-utils
jsch
mvn(com.jcraft:jsch)
mvn(commons-io:commons-io)
mvn(log4j:log4j)
mvn(org.codehaus.mojo:properties-maven-plugin)
mvn(org.jboss:jboss-dmr)
mvn(org.slf4j:slf4j-api)
mvn(org.slf4j:slf4j-log4j12)
Provides
--------
openshift-java-client:
mvn(com.openshift:openshift-java-client)
openshift-java-client
MD5-sum check
-------------
https://github.com/openshift/openshift-java-client/archive/707370873280180663c7b4c8730c25db408ee624/openshift-java-client-2.0.3-7073708.tar.gz :
CHECKSUM(SHA256) this package : ea92722842c72f7898a8171c204e652c21d0d694c593d8cce05295c574596b0c
CHECKSUM(SHA256) upstream package : ea92722842c72f7898a8171c204e652c21d0d694c593d8cce05295c574596b0c
Generated by fedora-review 0.4.0 (660ce56) last change: 2013-01-29
Buildroot used: fedora-rawhide-x86_64
Command line :/usr/bin/fedora-review -n openshift-java-client -m fedora-rawhide-x86_64
*** NOT APPROVED ***
Issues described at the top of this comment.
> openshift-java-client: get rid of external class to (de)code base64
> -------------------------------------------------------------------
>
> Key: JBIDE-13812
> URL: https://issues.jboss.org/browse/JBIDE-13812
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: openshift
> Affects Versions: 4.1.0.Alpha2
> Reporter: Andre Dietisheim
> Assignee: Andre Dietisheim
> Fix For: 4.1.0.Alpha2
>
>
> We're currently using a class that we copied from a different project to (de)code base64. This contradicts the fedora project which wants to package us into an rpm. They suggested to package the full library instead.
> Since we dont want to agument the numbers of dependencies, I'll switch to JDK means to (de)code base64. This will bind us to >= JDK6 which is IMHO perfectly fine.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbosstools-issues
mailing list