[jbosstools-issues] [JBoss JIRA] (JBIDE-13812) openshift-java-client: get rid of external class to (de)code base64

[RH Bugzilla Integration (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764045#comment-12764045 ] 

RH Bugzilla Integration commented on JBIDE-13812:
-------------------------------------------------

Gerard Ryan <gerard at ryan.lt> made a comment on [bug 902017|https://bugzilla.redhat.com/show_bug.cgi?id=902017]

(In reply to comment #14)
> Package Review
> ==============
> 
> Key:
> [x] = Pass
> [!] = Fail
> [-] = Not applicable
> [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> 
> [!]: Changelog in prescribed format.
> >>>> There must either be a space on both sides of the delimiting dash, or
> >>>> no delimiting dash at all. I. e.
> >>>>   ...t.org> - 2.0.3-2 
> >>>> or 
> >>>>   ...t.org> 2.0.3-2

Fixed.

> [!]: Package complies to the Packaging Guidelines
> [!]: If (and only if) the source package includes the text of the license(s)
>      in its own file, then that file, containing the text of the license(s)
>      for the package is included in %doc.
> >>>> you should include 
> >>>>   %doc license epl-v10.html
> >>>> in %files and %files javadoc

Oops. I don't know how that got removed, thanks for pointing it out. Fixed.

> Notes:
> ======
> 
> [!]: Requires correct, justified where necessary.
> >>>> You don't need to specify Requires when building with %mvn_build

Fixed. I've left in Requires on jsch since it doesn't have a maven POM.


DIFF of specfile since previous uploaded version
===========================================================
@@ -4,7 +4,7 @@
 
 Name:           openshift-java-client
 Version:        2.0.3
-Release:        2.%{checkout}%{?dist}
+Release:        3.%{checkout}%{?dist}
 Summary:        OpenShift Java Client
 
 Group:          Development/Libraries
@@ -13,7 +13,6 @@ URL:            http://openshift.redhat.com
 Source0:        https://github.com/openshift/%{name}/archive/%{commit}/%{name}-%{version}-%{shortcommit}.tar.gz
 BuildArch: noarch
 
-BuildRequires: java-devel
 BuildRequires: maven-local
 BuildRequires: jsch
 BuildRequires: mvn(org.easytesting:fest-assert)
@@ -25,11 +24,6 @@ BuildRequires: mvn(log4j:log4j)
 BuildRequires: mvn(org.codehaus.mojo:properties-maven-plugin)
 BuildRequires: mvn(commons-io:commons-io)
 Requires: jsch
-Requires: mvn(org.jboss:jboss-dmr)
-Requires: mvn(org.slf4j:slf4j-log4j12)
-Requires: mvn(commons-io:commons-io)
-Requires: mvn(org.codehaus.mojo:properties-maven-plugin)
-Requires: java
 
 %description
 This is a client for OpenShift written in java. It pretty much offers all
@@ -57,13 +51,20 @@ API documentation for %{name}.
 
 %files -f .mfiles
 %dir %{_javadir}/%{name}
+%doc license epl-v10.html
 
 %files javadoc -f .mfiles-javadoc
+%doc license epl-v10.html
 
 %changelog
-* Wed Mar 20 2013 Gerard Ryan <galileo at fedoraproject.org> -2.0.3-2
+* Fri Mar 29 2013 Gerard Ryan <galileo at fedoraproject.org> - 2.0.3-3
+- Fix changelog.
+- Remove unneeded Requires.
+- Added epl-v10.html as a doc to main and javadoc packages.
+
+* Wed Mar 20 2013 Gerard Ryan <galileo at fedoraproject.org> - 2.0.3-2
 - Update to fix licensing and new Base64Coder implementation.
 - Use new maven macros.
 
-* Sun Jan 20 2013 Gerard Ryan <galileo at fedoraproject.org> -2.0.3-1 
+* Sun Jan 20 2013 Gerard Ryan <galileo at fedoraproject.org> - 2.0.3-1
 - Initial package.

=========================================================================

Spec URL: http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client.spec
SRPM URL: http://galileo.fedorapeople.org/openshift-java-client/2.0.3-3/openshift-java-client-2.0.3-3.20130320git7073708.fc18.src.rpm
                
> openshift-java-client: get rid of external class to (de)code base64
> -------------------------------------------------------------------
>
>                 Key: JBIDE-13812
>                 URL: https://issues.jboss.org/browse/JBIDE-13812
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.0.Alpha2
>
>
> We're currently using a class that we copied from a different project to (de)code base64. This contradicts the fedora project which wants to package us into an rpm. They suggested to package the full library instead. 
> Since we dont want to agument the numbers of dependencies, I'll switch to JDK means to (de)code base64. This will bind us to >= JDK6 which is IMHO perfectly fine.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira