[jbosstools-issues] [JBoss JIRA] (JBIDE-13888) openshift-java-client: make sure useragent is sent

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764081#comment-12764081 ] 

Andre Dietisheim commented on JBIDE-13888:
------------------------------------------

There is also very weird code in the UrlConnectionHttpClientBuilder which holds user-agent building logic. IMHO this logic should be in the rest service, not in the builder since the user-agent should get built correctly even if you create the client directly or use the builder:

{code:title=UrlConnectionHttpClientBuilder}
	public IHttpClient client() {
		if (authKey != null && authKey.trim().length() > 0) {
			if (userAgent == null) {
				userAgent = "OpenShift";
			} else if (!userAgent.startsWith("OpenShift")) {
				userAgent = "OpenShift-" + userAgent;
			}
		}
		return new UrlConnectionHttpClient(username, password, userAgent,
				sslChecks, requestMediaType, acceptedMediaType, version,
				authKey, authIV);
	}

{code}
                
> openshift-java-client: make sure useragent is sent
> --------------------------------------------------
>
>                 Key: JBIDE-13888
>                 URL: https://issues.jboss.org/browse/JBIDE-13888
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.0.Alpha2
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira