[jbosstools-issues] [JBoss JIRA] (JBIDE-14393) openshift-java-client: should have integration test that asserts that app type is not reported in embedded cartridges

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12772797#comment-12772797 ] 

Andre Dietisheim commented on JBIDE-14393:
------------------------------------------

the new integration test is as follows:

{code:title=EmbeddedCartridgeResourceIntegrationTest}
@Test
	public void shouldNotContainTypeInEmbeddedCartridges() throws SocketTimeoutException, OpenShiftException {
		// pre-conditions
		final IStandaloneCartridge jbossAs = LatestVersionOf.jbossAs().get(user);
		assertThat(jbossAs).isNotNull();
		IApplication application = ApplicationTestUtils.ensureHasExactly1Application(jbossAs, domain);

		// operation
		List<IEmbeddedCartridge> embeddedCartridges = application.getEmbeddedCartridges();
		// verification
		assertThat(embeddedCartridges).doesNotSatisfy(new Condition<List<?>>() {

			@Override
			public boolean matches(List<?> values) {
				for(Object value : values) {
					if (!(value instanceof ICartridge)) {
						continue;
					}
					if (jbossAs.getName().equals(((ICartridge)value).getName())) {
						return true;
					};
				}
				return false;
			}
		});
	}
{code}
                
> openshift-java-client: should have integration test that asserts that app type is not reported in embedded cartridges
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-14393
>                 URL: https://issues.jboss.org/browse/JBIDE-14393
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Andre Dietisheim
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.0.Beta1
>
>
> In JBIDE-12321 we faced an issue where OpenShift would report the application type as embedded cartridge (which it does in protocol 1.2+). We should have an integration test that assert that this is not the case

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira