[jbosstools-issues] [JBoss JIRA] (JBIDE-14399) wise naming/implementation issues

[Max Rydahl Andersen (JIRA)]

Max Rydahl Andersen created JBIDE-14399:
-------------------------------------------

             Summary: wise naming/implementation issues
                 Key: JBIDE-14399
                 URL: https://issues.jboss.org/browse/JBIDE-14399
             Project: Tools (JBoss Tools)
          Issue Type: Feature Request
          Components: Webservices
            Reporter: Max Rydahl Andersen
            Assignee: Brian Fitzpatrick
             Fix For: 4.1.0.Beta1


the new addition of wise have a few quirks in naming and implementation.

plugin org.jboss.tools.wise -> org.jboss.tools.wise.ui

Reason: to match the rest of the plugins. Yes, it is mostly about bundling wise, but then it should on its own as org.jboss.tools.wise.core or org.jboss.tools.wise.runtime or similar. Not just org.jboss.tools.wise on its own. Since it also has helper code inside it I suggest to call it org.jboss.tools.ws.wise.ui and if one day it makes sense to isolate the jars in a wise specific plugin/bundle o.j.t.ws.wise or o.j.t.ws.wise.core it can just include it.

org.jboss.wise.ui overlaps with wise framework package domain, should be org.jboss.tools.ws.wise.ui

org.jboss.wise.ui.util.Activator - is this class actually needed ? if yes, shouldn't it be in org.jboss.ws.wise.ui.Activator ?

https://github.com/jbosstools/jbosstools-webservices/blob/master/plugins/org.jboss.tools.wise/src/org/jboss/wise/ui/util/WiseUtil.java#L57 has a method named getSampleSOAPInputMessage2 in what is marked as public API. I suggest rename and javadoc it to something sensible or move it to an internal package.

https://github.com/jbosstools/jbosstools-webservices/blob/master/plugins/org.jboss.tools.wise/src/org/jboss/wise/ui/util/WiseUtil.java#L85 and onward has a lot of ex.printstacktraces() - shouldn't these be handled/logged/ignored ?





--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira