[jbosstools-issues] [JBoss JIRA] (JBIDE-14410) Maven Test class importing internal class JBossASHandler

[Snjezana Peco (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-14410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Snjezana Peco resolved JBIDE-14410.
-----------------------------------

    Resolution: Rejected


This test can't solved in another way.
                
> Maven Test class importing internal class JBossASHandler
> --------------------------------------------------------
>
>                 Key: JBIDE-14410
>                 URL: https://issues.jboss.org/browse/JBIDE-14410
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Rob Stryker
>            Assignee: Snjezana Peco
>            Priority: Critical
>             Fix For: 4.1.0.Beta1
>
>
> ./jbosstools-central/maven/tests/org.jboss.tools.maven.sourcelookup.test/src/org/jboss/tools/maven/sourcelookup/test/SourceLookupTest.java has the following method:
> {code}
>  private static IRuntimeDetectorDelegate getJBossASHandler() {
>                 Set<IRuntimeDetector> detectors = RuntimeCoreActivator.getDefault().getRuntimeDetectors();
>                 for (IRuntimeDetector detector:detectors) {
>                         IRuntimeDetectorDelegate delegate = ((RuntimeDetector)detector).getDelegate();
>                         if (delegate instanceof JBossASHandler) {
>                                 return delegate;
>                         }
>                 }
>                 return null;
>         }
> {code}
> The class and its package name are not technically API. It would be best if you instead compared against the handler's id:  org.jboss.tools.runtime.handlers.JBossASHandler
> Since this ID is declared in plugin.xml, it's best if you hard-code the string. 
> Trying to clean up people who depend on my internal classes so that I can get to organizing stuff properly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira