[jbosstools-issues] [JBoss JIRA] (JBDS-2630) include org.eclipse.jst.server_adapters.ext.feature and org.eclipse.jst.server_core.feature in JBDS instead of org.eclipse.jst.server.websphere.core plugin (since no longer exists in WTP 3.5M7)

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12774649#comment-12774649 ] 

Rob Stryker commented on JBDS-2630:
-----------------------------------

What files are we looking at? 

As far as I know, we have no requirements on websphere, jonas, or generic.jboss, and we do not really want or care if they are installed at all.  We do have some tests that run against tomcat, and it's useful to have tomcat in jbds. 

So again, what files are we looking at for what needs to change?
                
> include org.eclipse.jst.server_adapters.ext.feature and org.eclipse.jst.server_core.feature in JBDS instead of org.eclipse.jst.server.websphere.core plugin (since no longer exists in WTP 3.5M7)
> -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBDS-2630
>                 URL: https://issues.jboss.org/browse/JBDS-2630
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: P2 Enabled Product
>    Affects Versions: 7.0.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 7.0.0.Beta1
>
>
> Looks like org.eclipse.jst.server.websphere.core_1.0.302.v20080620.jar was removed from WTP after 3.5M6 [0,1]
> It used to be part of org.eclipse.jst.server_adapters.ext.feature_3.3.103.v20130312_1615-67CFHvBgJ9Bc9WGMFHKI8.jar
> So, I propose we include org.eclipse.jst.server_adapters.ext.feature in com.jboss.jbds.product.feature/feature.xml [2] instead of an itemized list of server adapter plugins.
> [0] http://download.jboss.org/jbosstools/updates/requirements/webtools/S-3.5.0M6-20130315194337/
> [1] http://download.jboss.org/jbosstools/updates/requirements/webtools/S-3.5.0M7-20130507050119/
> [2] https://svn.jboss.org/repos/devstudio/trunk/product/features/com.jboss.jbds.product.feature/feature.xml
> --
> Currently, JBDS product feature includes these server adapter plugins & features:
> {code}
> <import plugin="org.eclipse.jst.server.tomcat.core"/>
> <import plugin="org.eclipse.jst.server.tomcat.ui"/>
> <import plugin="org.eclipse.jst.server.websphere.core"/>
> <import plugin="org.eclipse.jst.server.generic.jonas"/>
> <import feature="org.eclipse.jst.server_ui.feature"/>
> <import feature="org.eclipse.jst.server_adapters.feature"/>
> {code}
> And the M7 version of the server_adapters.ext.feature includes these:
> {code}
> <plugin id="org.eclipse.jst.server.tomcat.core"/>
> <plugin id="org.eclipse.jst.server.tomcat.ui"/>
> <plugin id="org.eclipse.jst.server.websphere.core"/> *[removed]*
> <plugin id="org.eclipse.jst.server.generic.jboss"/>
> <plugin id="org.eclipse.jst.server.generic.jonas"/>
> {code}
> So this change would remove the missing websphere.core plugin in favour of the generic.jboss plugin.
> Also wondering if we should include org.eclipse.jst.server_core.feature in addition to org.eclipse.jst.server_ui.feature, which would bring in these two extra plugins:
> {code}
> <plugin id="org.eclipse.jst.server.core"/>
> <plugin id="org.eclipse.jst.server.generic.core"/>
> {code}
> [~rob.stryker] WDYT?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira