[jbosstools-issues] [JBoss JIRA] (JBIDE-13937) BrowserSim: syncronized devices changes after changing devices list

[Vlado Pakan (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-13937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775639#comment-12775639 ] 

Vlado Pakan edited comment on JBIDE-13937 at 5/21/13 9:56 AM:
--------------------------------------------------------------

Your uses case is correct. What do you thing about this one:

1. Open BrowserSim with iPhone5 skin
2. Open synchronized window with skin Galaxy S III
3. Delete first skin Desktop

There is no reason to change skin on those two BrowserSims from user point of view but it change iPhone5 skin to first available skin.

Another even more confusing scenario:

1. Open BrowserSim and uses 1st skin
2. Open Synchronized window with another skin
3. From Synchronized BrowserSim window remove 1st skin from Device list
4. BrowserSim using 1st skin is closed

There should be some dialog informing that BrowserSim is going to be closed because user just see disappearing BrowserSim window or in this case skin should be changed to first available skin.

I think selection in Device list should not affect displayed skin. It's confusing especially in case you have more BrowserSim windows opened. Device list is the same for both of them so when it's changed it's changed for both of them but only one BrowserSim window will change it's skin.

Or Device List could be changed to table with checkbox and current skin of BrowserSim will be checked in device label.

                
      was (Author: vpakan):
    Your uses case is correct. What do you thing about this one:

1. Open BrowserSim with iPhone5 skin
2. Open synchronized window with skin Galaxy S III
3. Delete first skin Desktop

There is no reason to change skin on those two BrowserSims from user point of view but it change iPhone5 skin to first available skin.

Another even more confusing scenario:

1. Open BrowserSim and uses 1st skin
2. Open Synchronized window with another skin
3. From Synchronized BrowserSim window remove 1st skin from Device list
4. BrowserSim using 1st skin is closed

There should be some dialog informing that BrowserSim is going to be closed because user just see disappearing BrowserSim window or in this case skin should be changed to first available skin.

I think selection in Device list should not affect displayed skin. It's confusing especially in case you have more BrowserSim windows opened. Device list is the same for both of them so when it's changed it's changed for both of them but only one BrowserSim window will change it's skin.

Or Device List could be changed to table with checkbox and current skin of BrowserSim will be checked in device label.
[~jjankovi]

                  
> BrowserSim: syncronized devices changes after changing devices list
> -------------------------------------------------------------------
>
>                 Key: JBIDE-13937
>                 URL: https://issues.jboss.org/browse/JBIDE-13937
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: browsersim, Visual Page Editor core
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Konstantin Marmalyukov
>            Assignee: Konstantin Marmalyukov
>             Fix For: 4.1.0.Beta1
>
>
> *Steps to reproduce:*
> # Run BrowserSim
> # Select iPhone 5 skin if it is not selected
> # Click Context Menu > Open Synchronized Window > Galaxy S III
> # Open BrowserSim Preferences window and remove the first skin (Desktop) from the list
> # Click OK in the Preferences window
> *Actual behavior:*
> iPhone 5 skin is changed to selected in preferences during deletion, Galaxy S III is changed to Samsung Galaxy Tab
> *Expected behavior:*
> first skin is changed to selected in preferences during deletion and Galaxy S III skinstays as it is

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira