[jbosstools-issues] [JBoss JIRA] (JBIDE-14575) NPE in Eclipse logs if I cancel "add ssh key" dialog

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775934#comment-12775934 ] 

Andre Dietisheim commented on JBIDE-14575:
------------------------------------------

The usecase here is that we want wizard pages that only show up if certain conditions are met. In this case the ssh-keys wizard page (dialog) should only show up if the user has no keys in his OpenShift account yet. 
We currently pop up some dialog when the application configuration wizard page is to be shown (on page activation). If the user cancels this dialog, there's no sense to get further in the dialog, you cannot create and import an OpenShift application if you have no ssh keys. We therefore close and dispose the wizard. Since we do this while the main wizard (the application wizard) is intializing (we're in "on page activated") it'll get an NPE on the shell he's trying to use for his wizard-dialog.
                
> NPE in Eclipse logs if I cancel "add ssh key" dialog
> ----------------------------------------------------
>
>                 Key: JBIDE-14575
>                 URL: https://issues.jboss.org/browse/JBIDE-14575
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Stefan Bunciak
>             Fix For: 4.1.x
>
>
> {code}
> java.lang.NullPointerException
> 	at org.eclipse.jface.window.Window.initializeBounds(Window.java:759)
> 	at org.eclipse.jface.dialogs.Dialog.initializeBounds(Dialog.java:729)
> 	at org.eclipse.jface.window.Window.create(Window.java:436)
> 	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1104)
> 	at org.eclipse.jface.window.Window.open(Window.java:791)
> 	at org.jboss.tools.openshift.express.internal.ui.action.CreateApplicationAction.run(CreateApplicationAction.java:45)
> 	at org.eclipse.jface.action.Action.runWithEvent(Action.java:499)
> 	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:584)
> 	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:501)
> 	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:411)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1392)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3717)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3338)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1108)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:992)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:137)
> 	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:600)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> 	at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira