[jbosstools-issues] [JBoss JIRA] (JBIDE-14448) Build doesn't detect cycle dependencies between JBossTools modules

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775981#comment-12775981 ] 

Mickael Istria commented on JBIDE-14448:
----------------------------------------

> in mvn you would do it via changing the version in the pom.xml. would it make sense to add it to root pom.xml for each component which branch its using ?

I don't think it's a good practice to put the branch in the pom, as it means that whenever we change branch, we need to update the pom. So we can't use simple tagging for example.
It's for example what is forcing us to change the current parent pom now, and our main remaining obstacle to be able to release it.
                
> Build doesn't detect cycle dependencies between JBossTools modules
> ------------------------------------------------------------------
>
>                 Key: JBIDE-14448
>                 URL: https://issues.jboss.org/browse/JBIDE-14448
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Denis Golovin
>            Assignee: Nick Boldt
>
> Currently every component references nightly composite update site during the build to get dependencies. That leads to possibility to introduce cycle dependencies between components that is not detected by build.
> Here is example of PR introduced a cycle between JST and VPE. Build works because JST have access to VPE BrowserSim through nightly composite update site.
> The solution would be to reference specific nightly update sites for modules that are dependencies for current one. 
> In this case JST should have reference only to base composite nightly update site. That would solve cycle dependency detection problem and speed up the build because it would not require to download and analyse all metadata from jbosstools nightly composite update site.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira