[jbosstools-issues] [JBoss JIRA] (JBIDE-14448) Build doesn't detect cycle dependencies between JBossTools modules

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776491#comment-12776491 ] 

Mickael Istria commented on JBIDE-14448:
----------------------------------------

I like this approach, and that's what we do for our Maven plugins and target platforms (so we actually only tag, and generally don't branch). It's more focused on the version we target rather than on the location of the code.

This would require to stop having sites "/4.1.kepler" and "/trunk" but instead have sites for targeted version. For example, we would have sites saying "/4.1.0.Beta2" instead of "trunk" so when we branch master for 4.1.0.Beta2, we don't need to change the pom to ensure isolation. Instead, we update master to point to 4.1.0.CR1.

This is a smart change and that's IMO the way to go, however, it will require us a lot of risky changes on the way we publish/consume sites.




                
> Build doesn't detect cycle dependencies between JBossTools modules
> ------------------------------------------------------------------
>
>                 Key: JBIDE-14448
>                 URL: https://issues.jboss.org/browse/JBIDE-14448
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: Build/Releng
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Denis Golovin
>            Assignee: Nick Boldt
>
> Currently every component references nightly composite update site during the build to get dependencies. That leads to possibility to introduce cycle dependencies between components that is not detected by build.
> Here is example of PR introduced a cycle between JST and VPE. Build works because JST have access to VPE BrowserSim through nightly composite update site.
> The solution would be to reference specific nightly update sites for modules that are dependencies for current one. 
> In this case JST should have reference only to base composite nightly update site. That would solve cycle dependency detection problem and speed up the build because it would not require to download and analyse all metadata from jbosstools nightly composite update site.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira