[jbosstools-issues] [JBoss JIRA] (JBIDE-14539) Error when viewing source of page and VPE is set as default HTML editor

[Yahor Radtsevich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776911#comment-12776911 ] 

Yahor Radtsevich edited comment on JBIDE-14539 at 5/24/13 12:19 PM:
--------------------------------------------------------------------

Added simple null-checks.
[~scabanovich] could you please check if these pull-requests correct?
                
      was (Author: yradtsevich):
    Added simple null-checks.
[~vkabanovich] could you please check if these pull-requests correct?
                  
> Error when viewing source of page and VPE is set as default HTML editor
> -----------------------------------------------------------------------
>
>                 Key: JBIDE-14539
>                 URL: https://issues.jboss.org/browse/JBIDE-14539
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: browsersim
>    Affects Versions: 4.1.0.Beta1
>         Environment: JBDS 7.0.0 Beta1-v20130519-0601-B206, Linux 64bit, Java Sun 1.6
>            Reporter: Vlado Pakan
>            Assignee: Viacheslav Kabanovich
>            Priority: Critical
>              Labels: respin-a
>             Fix For: 4.1.0.Beta1
>
>
> 1. Open Window > Preferences > General > Editors > File Associations
> 2. Select *.HTML as File type
> 3. Select JBoss Tools HTML Editor and set it as default
> 4. Open page www.jboss.org in BrowserSim
> 5. Choose context menu View Page Source
> ERROR: Error dialog is displayed and this error appears in Error Log:
> Problems occurred when invoking code from plug-in: "org.eclipse.ui.workbench".
> {noformat}
> java.lang.NullPointerException
> 	at org.jboss.tools.jst.jsp.jspeditor.PalettePageImpl.attach(PalettePageImpl.java:64)
> 	at org.jboss.tools.jst.jsp.jspeditor.JSPMultiPageEditor.getAdapter(JSPMultiPageEditor.java:729)
> 	at org.eclipse.gef.ui.views.palette.PaletteView.doCreatePage(PaletteView.java:101)
> 	at org.eclipse.ui.part.PageBookView.createPage(PageBookView.java:411)
> 	at org.eclipse.ui.part.PageBookView.partActivated(PageBookView.java:754)
> 	at org.eclipse.ui.part.PageBookView$4.partActivated(PageBookView.java:1044)
> 	at org.eclipse.ui.internal.WorkbenchPage$12.run(WorkbenchPage.java:4541)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.ui.internal.WorkbenchPage.firePartActivated(WorkbenchPage.java:4539)
> 	at org.eclipse.ui.internal.WorkbenchPage.access$16(WorkbenchPage.java:4519)
> 	at org.eclipse.ui.internal.WorkbenchPage$E4PartListener.partActivated(WorkbenchPage.java:181)
> 	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl$2.run(PartServiceImpl.java:192)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.firePartActivated(PartServiceImpl.java:190)
> 	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:588)
> 	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:548)
> 	at org.eclipse.e4.ui.internal.workbench.PartServiceImpl.activate(PartServiceImpl.java:537)
> 	at org.eclipse.ui.internal.WorkbenchPage.busyOpenEditor(WorkbenchPage.java:3131)
> 	at org.eclipse.ui.internal.WorkbenchPage.access$22(WorkbenchPage.java:3048)
> 	at org.eclipse.ui.internal.WorkbenchPage$8.run(WorkbenchPage.java:3030)
> 	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> 	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:3026)
> 	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2990)
> 	at org.eclipse.ui.internal.WorkbenchPage.openEditor(WorkbenchPage.java:2973)
> 	at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback.openInMemoryHtmlEditor(ViewSourceCallback.java:90)
> 	at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback.access$0(ViewSourceCallback.java:73)
> 	at org.jboss.tools.vpe.browsersim.eclipse.callbacks.ViewSourceCallback$1.run(ViewSourceCallback.java:68)
> 	at org.eclipse.swt.widgets.RunnableLock.run(RunnableLock.java:35)
> 	at org.eclipse.swt.widgets.Synchronizer.runAsyncMessages(Synchronizer.java:135)
> 	at org.eclipse.swt.widgets.Display.runAsyncMessages(Display.java:3692)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3341)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1108)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:992)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:137)
> 	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:600)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:555)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:124)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:110)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:79)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:354)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:181)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
> 	at java.lang.reflect.Method.invoke(Method.java:597)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:636)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:591)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1450)
> 	at org.eclipse.equinox.launcher.Main.main(Main.java:1426)
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira