[jbosstools-issues] [JBoss JIRA] (JBIDE-14663) Source lookup dialog shown twice on maven projects

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777921#comment-12777921 ] 

Fred Bricon commented on JBIDE-14663:
-------------------------------------

Jars out of the maven classpath library are irrelevant. Whoever does that is shooting himself in the foot. We don't have to support that scenario.
You already proved source attachments couldn't use variables, so be it. In the case of maven projects, it's not important since the hardcoded path is stored at the workspace level, not in .classpath that is shared among developers.

Since we have not other way to provide source attachments, we warn the users about hardcoded paths. I think it's acceptable.

The double dialog issue was not caused/related to maven. However, the screencast clearly shows maven does its thing in the background, while we ask the user if we should proceed. We have *two* source lookup mechanisms running concurrently. This is wrong IMO, hence the reason why I wanted to treat maven differently. 

I understand the advantages of your source lookup mechanism over m2e's, really, but I've never seen any bug report about mismatch sources in m2e. If that was really a problem, source validation could also be implemented directly in m2e.

So I'm -0 about the "Enable Source Lookup for maven projects". 

 
                
> Source lookup dialog shown twice on maven projects
> --------------------------------------------------
>
>                 Key: JBIDE-14663
>                 URL: https://issues.jboss.org/browse/JBIDE-14663
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Fred Bricon
>            Assignee: Fred Bricon
>              Labels: respin-b
>             Fix For: 4.1.0.Beta1
>
>
> Source lookup dialog is shown twice on maven projects : http://screencast.com/t/3yESat96FIw
> I think our source lookup should ignore projects with the maven nature, since a m2e's source lookup mechanism is already running in the background.
> If maven nature is enabled AND source is set but missing THEN, it'd be ok to show our own stuff

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira