[jbosstools-issues] [JBoss JIRA] (JBIDE-14694) Cheatsheet is not opened when importing project as existing one

Snjezana Peco (JIRA) jira-events at lists.jboss.org
Thu May 30 11:58:54 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-14694?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12778283#comment-12778283 ] 

Snjezana Peco commented on JBIDE-14694:
---------------------------------------

The issue has been caused by https://github.com/jbosstools/jbosstools-central/pull/112
The PR supposes Eclipse always notifies resource change listeners with one notification which isn't correct.

When importing an existing project, Eclipse works as follows:

- creates a project (adds the .project file) and notifies resource change listeners
In that moment, createdProject[0] = true, but a cheatsheet isn't added and shown
- adds other project's resources and notifies resource change listeners
A cheatcheet is added, but createdProject[0] = false so the cheatsheet isn't shown again.

I think there is no way to distinguish how a resource (cheatsheet) is added to a project because we can't suppose that Eclipse will notify an event for all changes.

What we can do is the following:

- keep https://github.com/jbosstools/jbosstools-central/pull/112
In this case, a cheatsheet will be opened when importing a maven project, but won't be opened in some other cases what depends on how Eclipse notifies resource changes listeners. In the case of the change of the importing maven project procedure, it could happen that a cheatsheet isn't opened even if a maven project is imported.
When adding a cheatsheet to an existing project, it won't be opened. The PR fixes this case correctly. 

- remove https://github.com/jbosstools/jbosstools-central/pull/112
A cheatsheet will be opened no matter how it has been added to the workspace: importing a project, opening a project, adding the cheatcheet to an existing project ...

When closing/opening a project, a cheatsheet will be opened with and without this PR.

                
> Cheatsheet is not opened when importing project as existing one
> ---------------------------------------------------------------
>
>                 Key: JBIDE-14694
>                 URL: https://issues.jboss.org/browse/JBIDE-14694
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: project-examples
>    Affects Versions: 4.1.0.Beta1
>            Reporter: Rastislav Wagner
>            Assignee: Snjezana Peco
>             Fix For: 4.1.0.Beta2
>
>         Attachments: jboss-as-kitchensink.zip
>
>
> When I try to import project via Existing projects into workspace no cheatsheet is opened. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list