[jbosstools-issues] [JBoss JIRA] (JBIDE-15779) Plugin removed via config.xml editor is not removed from <project>/plugins directory

[Gorkem Ercan (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829602#comment-12829602 ] 

Gorkem Ercan edited comment on JBIDE-15779 at 11/1/13 7:29 PM:
---------------------------------------------------------------

Released a fix for this on master. But note that removing a plugin from config editor may not always give the expected results. Let me explain.

A plugin is identified by its id on the cordova land. However on the config.xml instead of ID a name is used to  identify a plugin. By convention, the name matches the name of the plugin (which is different from id) however there are cases where the name of the plugin and the name inserted to config.xml does not match. In those cases we fall back and just remove the config.xml bits. Also since name is not guaranteed to be unique like ID is we also always present a confirmation dialog where ID is present before removing a plugin. 

You can see a great example of this with the device-motion plugin.
                
      was (Author: gercan):
    Released a fix for this on master. But note that removing a plugin from config editor may not always give the expected results. Let me explain.

A plugin is identified by its id on the cordova land. However on the config.xml instead of ID a name is used to  identify a plugin. By convention, the name matches the name of the plugin (which is different from id) however there are cases where the name of the plugin and the name inserted to config.xml does not match. In those cases we fall back and just remove the xml bits. Also since name is not guaranteed to be unique like ID is we also always present a confirmation dialog where ID is present before removing a plugin. 

You can see a great example of this with the device-motion plugin.
                  
> Plugin removed via config.xml editor is not removed from <project>/plugins directory
> ------------------------------------------------------------------------------------
>
>                 Key: JBIDE-15779
>                 URL: https://issues.jboss.org/browse/JBIDE-15779
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: aerogear-hybrid
>    Affects Versions: 4.1.1.Beta1
>            Reporter: Vlado Pakan
>            Assignee: Gorkem Ercan
>             Fix For: 4.1.1.CR1
>
>
> Steps to reproduce:
> 1. Create new Hybrid Mobile project
> 2. Open project config.xml file, add some feature on tab. Platform Properties and save
> ASSERT: Respective plugins are added to project plugins directory
> 3, Remove added feature from config.xml file similar way as in point 2.
> ERROR: Removed plugin is still in plugins directory. When project is built for Android via calling menu Run As > Run on Android Emulator. This plugin is added to built project and it's not correct

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira