[jbosstools-issues] [JBoss JIRA] (JBIDE-15858) Application wizard: server that does not support env variables causes error when creating app

[Andre Dietisheim (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-15858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andre Dietisheim updated JBIDE-15858:
-------------------------------------

               Summary: Application wizard: server that does not support env variables causes error when creating app  (was: Edit environment variables: trying to edit env variables on server that does not support it causes error when creating app)
    Steps to Reproduce: 
# ASSERT: make sure you have an account on a OS server that does *NOT* support env variables (ex. console.itos.redhat.com)
# ASSERT: make sure you have an existing application on this server
# EXEC: in OpenShift Explorer: pick "Edit Environment Variables..." in the context menu of your application

Result:
You get an error:
!environment_variables.png!

In the Eclipse log you'll spot the following:
{code}
com.openshift.client.OpenShiftRequestException: Could not find link "LIST_ENVIRONMENT_VARIABLES" in resource "ApplicationResource"
	at com.openshift.internal.client.AbstractOpenShiftResource.getLink(AbstractOpenShiftResource.java:123)
	at com.openshift.internal.client.AbstractOpenShiftResource$ServiceRequest.execute(AbstractOpenShiftResource.java:142)
	at com.openshift.internal.client.ApplicationResource.loadEnvironmentVariables(ApplicationResource.java:622)
	at com.openshift.internal.client.ApplicationResource.getOrLoadEnvironmentVariables(ApplicationResource.java:616)
	at com.openshift.internal.client.ApplicationResource.getEnvironmentVariables(ApplicationResource.java:611)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariablesFor(EnvironmentVariablesWizardModel.java:81)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.initVariables(EnvironmentVariablesWizardModel.java:64)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardModel.loadEnvironmentVariables(EnvironmentVariablesWizardModel.java:58)
	at org.jboss.tools.openshift.express.internal.ui.wizard.environment.EnvironmentVariablesWizardPage$LoadEnvironmentVariablesJob.doRun(EnvironmentVariablesWizardPage.java:240)
	at org.jboss.tools.openshift.express.internal.ui.job.AbstractDelegatingMonitorJob.run(AbstractDelegatingMonitorJob.java:36)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
{code}

    
> Application wizard: server that does not support env variables causes error when creating app
> ---------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-15858
>                 URL: https://issues.jboss.org/browse/JBIDE-15858
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.1.Beta1
>            Reporter: Marián Labuda
>            Assignee: Andre Dietisheim
>             Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>         Attachments: environment_variables.png
>
>
> If OpenShift server does not support add/remove/modify environment variables it cause error. There should be some user-friendly dialog. See attached image. This is captured from opening shell with add/modify/remove environment variables (in context menu of application choose "Edit Environment Variables..."
> Another one is show after attempt to add variable.
> Other "Processing environment variables..."
> Probably good solution should show dialog "Server _name_ does not support modifying environment variables" and don't open shell with table of environment variables (my opinion). 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira