[jbosstools-issues] [JBoss JIRA] (JBIDE-15853) plugins w/o test classes should not be set to packaging=eclipse-test-plugin

Vlado Pakan (JIRA) jira-events at lists.jboss.org
Tue Nov 5 11:55:02 EST 2013


    [ https://issues.jboss.org/browse/JBIDE-15853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851055#comment-12851055 ] 

Vlado Pakan edited comment on JBIDE-15853 at 11/5/13 11:53 AM:
---------------------------------------------------------------

We prefer to leave swtbot.test.skip set to true. Because SWTBot test are still not very stable and so not skipping them will make build failed almost always and job will take much more time. As far as I remember it was the reason to introduce this property.

We are running all SWTBot tests on our local Jenkins instance and I think it's sufficient enough for now.
                
      was (Author: vpakan):
    We prefer to leave swtbot.test.skip set to true. Because SWTBot test are still not very stable and so not skipping them will make build failed almost always and job will take much more time. As far as I remember it was the reason to introduce this property.

We are running all SWTBot test on our local Jenkins instance and I think it's sufficient enough for now.
                  
> plugins w/o test classes should not be set to packaging=eclipse-test-plugin
> ---------------------------------------------------------------------------
>
>                 Key: JBIDE-15853
>                 URL: https://issues.jboss.org/browse/JBIDE-15853
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: testing-tools
>    Affects Versions: 4.1.1.Beta1
>            Reporter: Nick Boldt
>
> 4 plugins in jbosstools-integration-tests have no test classes, but are set via their pom to packaging type eclipse-test-plugin instead of eclipse-plugin.
> As a result, these four plugins fail to run tests and the resulting build is red.
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-integration-tests.aggregate_master/101/consoleFull}
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.archives.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.common.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.cdi.reddeer: No tests found.
> [ERROR] Failed to execute goal org.eclipse.tycho:tycho-surefire-plugin:0.18.1:test (default-test) on project org.jboss.tools.ws.reddeer: No tests found.
> {code}
> I propose that if these plugins are meant to be framework/API code, containing no actual JUnit tests to run, that their poms be changed as follows:
> {code}
> - <packaging>eclipse-test-plugin</packaging>
> + <packaging>eclipse-plugin</packaging>
> {code}
> And they be moved from 
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/tests/
> into 
> https://github.com/jbosstools/jbosstools-integration-tests/tree/master/plugins/

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list