[jbosstools-issues] [JBoss JIRA] (JBIDE-16161) Tycho tests require org.eclipse.osgi.compatibility.state fragment on Luna

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12927629#comment-12927629 ] 

Snjezana Peco commented on JBIDE-16161:
---------------------------------------

{quote}
You report is more focused on a solution than on the issue: In the case of base component, how does it fail? How do you see the error? Are tests at least starting?
{quote}

If you take a look at https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/job/jbosstools-base_master/383/
you will see the build is aborted after two hour timeout.
If you try it locally, you will see that a lot of services aren't started. The tests are started, but the most of them either freeze or fail.
For instance, CompatibilityEditor isn't initialized and all the tests that open a JBoss editor fail with a NPE.

{quote}
It seems to me that Tycho tests can generally run without PlatformAdmin being available (it probably depends on some test specificities). 
{quote}

See http://git.eclipse.org/c/tycho/org.eclipse.tycho.git/tree/tycho-surefire/org.eclipse.tycho.surefire.osgibooter/src/main/java/org/eclipse/tycho/surefire/osgibooter/Activator.java

The org.eclipse.tycho.surefire.osgibooter plugin won't start without the PlatformAdmin service, so a lot of the tests won't be run correctly.
The following message can be often seen in the log: "Could not acquire PlatformAdmin server".

{quote}
Most other components have successfully run their tests without change in parent pom. I'm not sure changing surefire configuration is the optimal solution.
{quote}

I can't find any components that build on https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/JBossTools/view/JBossTools_Master/
The most of them require the base component that isn't built.

Adding the o.e.e4.rcp feature would be the easiest solution. It is also possible to create a separate feature containing the compatibility fragment and include it to the main build or to every test separately.

You may also want to take a look at https://bugs.eclipse.org/bugs/show_bug.cgi?id=407097
                
> Tycho tests require org.eclipse.osgi.compatibility.state fragment on Luna
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-16161
>                 URL: https://issues.jboss.org/browse/JBIDE-16161
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.2.0.Alpha1
>            Reporter: Snjezana Peco
>            Assignee: Mickael Istria
>
> Since Tycho requires the PlatformAdmin service, we have to add the org.eclipse.osgi.compatibility.state fragment to tycho-surefire-plugin.
> The easiest way is to add the org.eclipse.e4.rcp feature to the main build.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira