[jbosstools-issues] [JBoss JIRA] (JBIDE-14018) OpenShift commit message references JBoss Tools

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12809094#comment-12809094 ] 

Max Rydahl Andersen commented on JBIDE-14018:
---------------------------------------------

[~erbarber] I think you are seeing this a bit too black and white :) The only time JBoss Tools adds this commit message is if you say Yes to having the server adapter commit the uncommitted code it finds before it is doing a Push.

This is a *completely* optional feature. You can simply say No and instead use normal egit commit features where you specify all the details you want, including even doing the push directly if you wish too.

Doing this doesn't even require more clicks - its simply just using "Team > Commit" on the project. Using this also allows you to add *new* files - something that the "commit before push" we currently provide does not.

Thus I find it very harsh and unfounded to state "unacceptable by the development teams and many developers are refusing to use the Eclipse plugins that you've provided".

You can simply use *all* the features of git available in eclipse to do this fine grained commit and cleanup of history you would like - the tools were built to allow for this flexibility.

That said, I agree we should allow for custom message to be set when doing commits BUT just be aware this does not cover the case where there are actually *new* files to add - in this case you still have to go use "Team > Commit" or "Team > Add"

I'm going to change this jira description to be about making this message configurable - but please do realize you have already eclipse UI for doing this. 






                
> OpenShift commit message references JBoss Tools
> -----------------------------------------------
>
>                 Key: JBIDE-14018
>                 URL: https://issues.jboss.org/browse/JBIDE-14018
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.1.0.Alpha2
>            Reporter: Michelle Murray
>            Assignee: Andre Dietisheim
>            Priority: Minor
>             Fix For: 4.2.x
>
>         Attachments: commit_from_JBT.png, Customized Git Commit on Publish.png
>
>
> In Servers tab, when you right-click on an OpenShift server adapter and click Publish, an automatic commit message is generated: "Commit from JBoss Tools".
> This message references JBoss Tools - for JBDS it should mention JBDS. I realise it is difficult to have a different message for JBT and JBDS so I guess the message needs to be changed to not reference either. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira