[jbosstools-issues] [JBoss JIRA] (JBIDE-15614) Rename EAP 6.1 server type to 6.1+, ensure runtime detection is accurate

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12813028#comment-12813028 ] 

Rob Stryker commented on JBIDE-15614:
-------------------------------------

Some more details on what went wrong here:

ServerBeanLoader.loadBeanInternal incorrectly call deprecated method getServerVersion(fullVersion). It should instead use getMajorMinorVersion, which is fairly new method.   The deprecated method getServerVersion had unclear semantics and was not useful in any way. 

In this specific case, the eap6.2 folder was recognized as an eap6.1 "type", and it's full version was recongized as 6.2, which is correct.  However, the server bean was instantiated with a version of 6.0, due to the badly performing getServerVersion method who's job it was to take the full version string and turn it into a more compact form. By using the newer method getMajorMinorVersion, the entire issue is fixed. 

Looking over this code, JBossServerType.getVersions() can also be deprecated, as there are no other clients using the method, and it would simplify the construction process drastically and require fewer updates. 


Other news about eap6.2:  Everything else seems to work fine.  Startup, shutdown, jmx, and others. 

                
> Rename EAP 6.1 server type to 6.1+, ensure runtime detection is accurate
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-15614
>                 URL: https://issues.jboss.org/browse/JBIDE-15614
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: runtime-detection, server
>    Affects Versions: 4.1.0.Final
>         Environment: JBDS 7.0.0.GA
>            Reporter: Martin Malina
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.1.1.Beta1
>
>
> 1. When you try to add EAP 6.2 using runtime detection, it detects it as EAP 6.0.
> 2. When trying to add EAP 6.2 manually, there is no type EAP 6.2
> Let me know if you want subtasks for these two.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira