[jbosstools-issues] [JBoss JIRA] (JBIDE-15647) Compile errors when building arquillian with Luna target platform

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12814165#comment-12814165 ] 

Snjezana Peco commented on JBIDE-15647:
---------------------------------------

{code}
which internal API would you remove that others in JBT uses ? 
{code}

No one component uses arquillian.
I have meant we can't use the same JBT code for Luna and Kepler because the most of our components (arquillian, central, project examples, maven, portlet, hibernate, archives, server, common, foundation, openshift... ) use internal Eclipse API.

{quote}
dont you mean stop using interal api or ?
{quote}

I mean we should stop using internal API whenever it is possible to do that.

{quote}
btw. this change sounds to me Eclipse are making public API internal between Kepler and Luna ?
{quote}

No, they aren't making public API internal.
The org.eclipse.osgi.framework.adaptor.BundleClassLoader class has been internal API and is renamed in Luna. 
However, it seems the RuntimeProcess class (JBIDE-15649 - forge) has been changed although it is a public API. Forge doesn't use internal API.

{quote}
That should be trivial to do dynamic test instead of hardcoded version ?
{quote}

I have removed the BundleClassLoader class because the Arquillian classloader isn't used within an Eclipse bundle. Now, the arquillian component builds against the Kepler and/or Luna target.


                
> Compile errors when building arquillian with Luna target platform
> -----------------------------------------------------------------
>
>                 Key: JBIDE-15647
>                 URL: https://issues.jboss.org/browse/JBIDE-15647
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: testing-tools
>    Affects Versions: 4.2.x
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>            Priority: Blocker
>             Fix For: 4.2.0.Alpha1
>
>
> When building the arquillian component with Luna TP(tpc.version=4.40.0.Alpha1-SNAPSHOT) there are the following compile errors:
> {code}
> [ERROR] import org.eclipse.osgi.framework.adaptor.BundleClassLoader;
> [ERROR] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> [ERROR] The import org.eclipse.osgi.framework.adaptor cannot be resolved
> [ERROR] 
> ...
> [ERROR] || tmp instanceof BundleClassLoader)
> [ERROR] ^^^^^^^^^^^^^^^^^
> [ERROR] BundleClassLoader cannot be resolved to a type
> {code}
> The errors are caused by the change of OSGi internals. 
> The org.eclipse.osgi.framework.adaptor package and the BundleClassloader class have been removed from Luna.
> The changes aren't compatible with the previous Eclipse versions, so we need a separate branch for Luna.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira