[jbosstools-issues] [JBoss JIRA] (JBIDE-15435) "installed plugins" detection seems fishy in project examples / central

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12814650#comment-12814650 ] 

Fred Bricon commented on JBIDE-15435:
-------------------------------------

Adding a new FeatureFix class would require a *lot* of changes across project-examples.

However, if we could keep the "plugin" fix type and add a *requiredIUs* property, like : 
{noformat}
<fix type="plugin">
  <property name="requiredIUs">org.eclipse.m2e.core.feature,org.eclipse.m2e.ui.feature</property>
  <property name="versions">[1.0.0,2.0.0)</property>
  <property name="description">This project example requires m2e &gt;= 1.0.</property>
  <property name="connectorIds">org.eclipse.m2e.feature</property>
</fix>
{noformat}

I *think* all required changes would need to be done inside the [PluginFix.canFix|https://github.com/jbosstools/jbosstools-central/blob/master/examples/plugins/org.jboss.tools.project.examples/src/org/jboss/tools/project/examples/fixes/PluginFix.java#L29]
We could even support *id* (i.e pluginId), *requiredIUs*, *requiredConnectors* in the same fix. PluginFix.canFix would return false as soon as one of the requirements isn't met. 

                
> "installed plugins" detection seems fishy in project examples / central
> -----------------------------------------------------------------------
>
>                 Key: JBIDE-15435
>                 URL: https://issues.jboss.org/browse/JBIDE-15435
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central, discovery, project-examples
>    Affects Versions: 4.1.0.Final
>            Reporter: Fred Bricon
>            Assignee: Fred Bricon
>             Fix For: 4.1.1.Beta1
>
>
> Following JBDS-2753, [~maxandersen] says he installed the JBoss GWT connector, which dragged the GPE plugins.
> Some functionality seem missing according to Max (which ones?). In the JBoss Central 'software updates' page, the GWT/GPE connector is shown as missing. In the GWT example wizard, the feature appears as installed. One of the 2 is wrong, obviously.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira