[jbosstools-issues] [JBoss JIRA] (JBIDE-15495) OpenShift server adapter: publish locks the whole workspace

Rob Stryker (JIRA) jira-events at lists.jboss.org
Thu Oct 17 08:45:02 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-15495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12822814#comment-12822814 ] 

Rob Stryker commented on JBIDE-15495:
-------------------------------------

As a summary of what's going on here,  the provided PRs were committed to both master and branch. However, it was revealed that the openshift server actually needs a full workspace lock, due to code in egit, and so this improvement is completely impossible for openshift. Sorry guys. 

On the bright side, the improvement will be working in all OTHER astools servers :D   So ASTools Servers will be much more efficient with workspace locking now! (yay!)

But this issue is essentially rejected or marked until later, since egit requires the workspace lock.   See CommitOperation#execute().  I feel this could be optimized such that egit could only lock the projects that share a repository with the repo being committed, but, even if it did that,  that set of projects may still be larger than the set of projects with modules being published, so... we'd still have to end our rule and let their rule take over for the commit and push portions. 

For now it makes sense that openshift requires a workspace lock., bc the egit methods do too.  But if egit ever optimized, then we should optimize in kind. 
                
> OpenShift server adapter: publish locks the whole workspace
> -----------------------------------------------------------
>
>                 Key: JBIDE-15495
>                 URL: https://issues.jboss.org/browse/JBIDE-15495
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: openshift, server
>    Affects Versions: 4.1.0.Final
>            Reporter: Xavier Coulon
>            Assignee: Rob Stryker
>              Labels: openshift_server_adapter
>             Fix For: 4.1.1.Beta1, 4.2.0.Alpha1
>
>         Attachments: Screen Shot 2013-09-17 at 10.42.43 AM.png
>
>
> Have 2 projects in a workspace, one of them is an OpenShift application
> Deploy some changes on OpenShift, and while the publication is performed (git push, then OS restarts the server), go to the second (unrelated) project and try to move a file from a package to another package in the same project.
> The 'Publish' operation locked the whoel workspace, which means that the move operation needs to wait.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list