[jbosstools-issues] [JBoss JIRA] (JBDS-2790) "JBoss Tools" themes should not be part of JBDS

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12823187#comment-12823187 ] 

Mickael Istria commented on JBDS-2790:
--------------------------------------

> https://github.com/jbdevstudio/jbdevstudio-product/blob/master/plugins/com.jboss.jbds.product/build.properties#L12
>./plugins/com.jboss.jbds.product/intro4/introContent.xml
> ./plugins/com.jboss.jbds.product/plugin_customization.ini
> ./plugins/com.jboss.jbds.product/themes/jbds/html/font-relative.css
> ./plugins/com.jboss.jbds.product/themes/jbds/html/shared.css
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/createnew.properties
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/gettingstarted.properties
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/perspectives.properties
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/root.properties
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/standby.properties
> ./plugins/com.jboss.jbds.product/themes/jbds/swt/webresources.properties

All those are actually related to the intro, and are out of the scope of this bug.

> ./plugins/com.jboss.jbds.product/plugin.xml

This one explicitly enables the default theme, so it's good to keep it.

> ./site/index.html

This is a generated file, it's not on Git.

> ./site/category.xml

Those are actually commented.

So could you please reconsider this PR?
                
> "JBoss Tools" themes should not be part of JBDS
> -----------------------------------------------
>
>                 Key: JBDS-2790
>                 URL: https://issues.jboss.org/browse/JBDS-2790
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: central
>    Affects Versions: 6.0.1.GA, 7.0.1.GA
>            Reporter: Max Rydahl Andersen
>            Assignee: Mickael Istria
>             Fix For: 7.1.0.Beta1, 8.0.0.Alpha1
>
>
> "JBoss Tools" themes seem to be included in JBDS even though JBDS-2631 was rejected and not supposed to be included.
> Now users are reporting issues on them in JBDS-2781 and JBDS-2782 we'll need to decide what to with them.
> My suggestion is we remove them in JBDS 8 and if a missing theme does not affect a user having already used these themes I suggest we remove them in JBDS 7.1 too.
> Thus setting suggested release target to 7.1 but if investigation shows it will hurt update path then at least remove them in 8.0.
> WDYT ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira