[jbosstools-issues] [JBoss JIRA] (JBDS-2790) "JBoss Tools" themes should not be part of JBDS

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12823225#comment-12823225 ] 

Nick Boldt edited comment on JBDS-2790 at 10/18/13 11:46 AM:
-------------------------------------------------------------

What happens on update? If a user has com.jboss.jbds.product.feature installed, which includes org.jboss.tools.central.themes.feature, and we remove it from a newer version... does it break anything?

I've verified I can update from JBDS 7.0.1 to locally-built 7.1.x. Result is that the org.jboss.tools.central.themes.feature_1.2.0.Final-v20130719-2050-B70 feature folder disappears, but the org.jboss.tools.central.themes_1.2.0.Final-v20130719-2050-B70.jar plugin remains.

However, it is not active:

{code}
./jbdevstudio -debug -console -consolelog
{code}

then
{code}
osgi> ss theme

id	State       Bundle
221	ACTIVE      org.eclipse.e4.ui.css.swt.theme_0.9.100.v20130515-1857
{code}

So, +1 for this PR, I'll apply it in all three branches: 4.1.1.Beta1x, 4.1.x, and master.
                
      was (Author: nickboldt):
    What happens on update? If a user has com.jboss.jbds.product.feature installed, which includes org.jboss.tools.central.themes.feature, and we remove it from a newer version... does it break anything?
                  
> "JBoss Tools" themes should not be part of JBDS
> -----------------------------------------------
>
>                 Key: JBDS-2790
>                 URL: https://issues.jboss.org/browse/JBDS-2790
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: central
>    Affects Versions: 6.0.1.GA, 7.0.1.GA
>            Reporter: Max Rydahl Andersen
>            Assignee: Mickael Istria
>             Fix For: 7.1.0.Beta1, 8.0.0.Alpha1
>
>
> "JBoss Tools" themes seem to be included in JBDS even though JBDS-2631 was rejected and not supposed to be included.
> Now users are reporting issues on them in JBDS-2781 and JBDS-2782 we'll need to decide what to with them.
> My suggestion is we remove them in JBDS 8 and if a missing theme does not affect a user having already used these themes I suggest we remove them in JBDS 7.1 too.
> Thus setting suggested release target to 7.1 but if investigation shows it will hurt update path then at least remove them in 8.0.
> WDYT ?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira