[jbosstools-issues] [JBoss JIRA] (JBIDE-15765) JPP 6.1 recognized as AS 7.2

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12824927#comment-12824927 ] 

Rob Stryker commented on JBIDE-15765:
-------------------------------------

JBossTools detects servers based on a set of assumptions, specifically file layout. It was our understanding that all of our assumptions were actual contracts, not just assumptions.  I will list the assumptions below:

1) any eap-based product will have a slot listed in bin/product.conf
2) any eap-based product will have a list of layers in modules/layers.conf
3) A manifest.mf file may be found for your slot's information at "modules/system/layers/base/org/jboss/as/product/" + slot + "/dir/META-INF"
4) A manifest.mf file may be found for each layer at: "modules/system/layers/" + layer + "/org/jboss/as/product/" + layer + "/dir/META-INF"

It's possible these assumptions only hold true for official slots and layers, and that other system paths may be used for extensions not contributed by JBoss. But for this I'm unaware, and we never fully spec'd it out. 

It was our assumption that in these folders, there would be manifest.mf files that would give specific details about the release, such as the release name and version. 

For example, JPP 6.1 ER3  had the following contents at path: jboss-jpp-6.1.0.ER03.zip.expanded/jboss-jpp-6.1/modules/system/layers/base/org/jboss/as/product/jpp/dir/META-INF/MANIFEST.MF:

JBoss-Product-Release-Name: Portal Platform
JBoss-Product-Release-Version: 6.1.0.ER03
JBoss-Product-Console-Slot: jpp


Today, that folder does not exist, and has instead been replaced with jboss-jpp-6.1.0.ER03.zip.expanded/jboss-jpp-6.1/modules/system/layers/base/org/jboss/as/product/eap/dir/META-INF/MANIFEST.MF

The contents of this new folder are:

JBoss-Product-Release-Name: EAP
JBoss-Product-Release-Version: 6.1.1.GA
JBoss-Product-Console-Slot: eap



                
> JPP 6.1 recognized as AS 7.2
> ----------------------------
>
>                 Key: JBIDE-15765
>                 URL: https://issues.jboss.org/browse/JBIDE-15765
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection
>    Affects Versions: 4.1.1.Beta1
>            Reporter: Radoslav Rábara
>            Assignee: Rob Stryker
>            Priority: Critical
>              Labels: respin-a
>             Fix For: 4.1.1.Beta1
>
>         Attachments: jpp 6.1 recognized as AS 72.jpg
>
>
> JBoss Portal 6.1.0 Final is recognized as AS 7.2 in JBoss Runtime Detection (Type: AS, Version: 7.2). However, JPP 6.1.0 Beta is recognized correctly as JPP 6.1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira