[jbosstools-issues] [JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801073#comment-12801073 ] 

Rob Stryker edited comment on JBIDE-15392 at 9/3/13 6:07 AM:
-------------------------------------------------------------

I'm in the middle of making a patch, but, it does seem strange to me. Perhaps I don't understand the use-case well enough. But it seems to me that both of these should be returning the same thing. 

The two usecases are:
  1) Classpath on a project such as a dynamic web project
  2) Your source locator (which seems to pull the same jars)

It seems that the two usecases are nearly identical and should require identical code. 

1) why doesn't your requirements need the "client" folder for AS <= 6.x? We add the client folder to all of our as<=6.x providers. 

2) I have not found any distribution which has a server/default/deploy/lib. So I'm not sure why you'd need that folder

3) Why do you need jboss-modules.jar?  Do you think it should also be added a dynamic web project's classpath as well? 

I think we should discuss any and all discrepencies between what the current classpath code does and the jars you are looking for. Is there a valid use case reason why any one jar would belong to your result set but NOT to my result set (or vice versa?)  Or should the two result sets basically be identical? 
                
      was (Author: rob.stryker):
    I'm in the middle of making a patch, but, it does seem strange to me. Perhaps I don't understand the use-case well enough. But it seems to me that both of these should be returning the same thing. 

The two usecases are:
  1) Classpath on a project such as a dynamic web project
  2) Your source locator (which seems to pull the same jars)

It seems that the two usecases are nearly identical and should require identical code. 

1) why doesn't your requirements need the "client" folder for AS <= 6.x? We add the client folder to all of our as<=6.x providers. 

2) I have not found any distribution which has a server/{config}/deploy/lib. So I'm not sure why you'd need that folder

3) Why do you need jboss-modules.jar?  Do you think it should also be added a dynamic web project's classpath as well? 

I think we should discuss any and all discrepencies between what the current classpath code does and the jars you are looking for. Is there a valid use case reason why any one jar would belong to your result set but NOT to my result set (or vice versa?)  Or should the two result sets basically be identical? 
                  
> Add api in server needed for source lookup
> ------------------------------------------
>
>                 Key: JBIDE-15392
>                 URL: https://issues.jboss.org/browse/JBIDE-15392
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven, server
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira