[jbosstools-issues] [JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802837#comment-12802837 ] 

Snjezana Peco commented on JBIDE-15392:
---------------------------------------

The PR looks fine for me.
I am using the following code:

{code}
HashMap<String, String> map = new HashMap<String, String>();
String configPath = new File(homePath, "server/default").getAbsolutePath();
map.put(RuntimeJarUtility.CONFIG_DIR, configPath);
IPath[] paths = new RuntimeJarUtility().getJarsForRuntimeHome(homePath, RuntimeJarUtility.ALL_JARS, map);
{code}

You could add jars for a default configuration for JBoss AS < 7.0 if nothing is specified, so we could use the following:

{code}
IPath[] paths = new RuntimeJarUtility().getJarsForRuntimeHome(homePath, RuntimeJarUtility.ALL_JARS);
{code}

or you could add one more method:

{code}
IPath[] getJarsForRuntimeHome(String home, int type, boolean useDefaultConfiguration)
{code}

If useDefaultConfiguration=true, you would add the jars from the default configuration.
                
> Add api in server needed for source lookup
> ------------------------------------------
>
>                 Key: JBIDE-15392
>                 URL: https://issues.jboss.org/browse/JBIDE-15392
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven, server
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Alpha1
>
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira