[jbosstools-issues] [JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup

Max Rydahl Andersen (JIRA) jira-events at lists.jboss.org
Tue Sep 10 06:02:03 EDT 2013


    [ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803027#comment-12803027 ] 

Max Rydahl Andersen commented on JBIDE-15392:
---------------------------------------------

never mind....now I get it.

You need the api to work as if you had a real server, but you only have a directory ?

If sourcelookup have to mess with "new File(homePath, "server/default").getAbsolutePath();" that leaks alot of knowledge into sourcelookup which just isn't necessary.

Wouldn't it be the simplest to be able to create a class that provides all these default settings for the server type based on result from the beanloaders ?

And seriously - why can't sourcelookup just know about the runtime and if it does not know about it simply just return all jars ? then all this custom knowledge in sourcelookup goes away ?

                
> Add api in server needed for source lookup
> ------------------------------------------
>
>                 Key: JBIDE-15392
>                 URL: https://issues.jboss.org/browse/JBIDE-15392
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven, server
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Alpha1
>
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list