[jbosstools-issues] [JBoss JIRA] (JBIDE-15392) Add api in server needed for source lookup

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803412#comment-12803412 ] 

Snjezana Peco commented on JBIDE-15392:
---------------------------------------

{quote}
"A source lookup container knows only a home directory" - you keep repeating this but why don't we make it so it can use either a home directory (and then just scans for all jars) or a specific server which would then be able to provide much more specific knowledge like this API jboss servers could expose ?

Similar could be made for tomcats etc. if this was setup as an extension point where runtime type was mapped to a class that could handle it.
{quote}

It is possible to make specific containers for different server types.
The PR from JBIDE-13851 recognizes a server type and scans jars based on it.
However, this jira is created in order to introduce a new API that would provide the Source Lookup plugin not to depend on a server type, i.e., we wouldn't change the Source Lookup plugin when a new sever type is introduced. 
The PR looks fine and can already be used. It would be just good the API to return jars for a default configuration for JBoss AS < 7.0. That isn't obliged, but can be easily added.

Creating a specific container for Tomcat, Glassfish... would require introducing new dependencies. In my opinion, they would need to be created in separate plugins.

                
> Add api in server needed for source lookup
> ------------------------------------------
>
>                 Key: JBIDE-15392
>                 URL: https://issues.jboss.org/browse/JBIDE-15392
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: maven, server
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Alpha1
>
>
> As uncovered in https://github.com/jbosstools/jbosstools-central/pull/128/files#L5L120 we got a problem with source lookup code always having to play catchup with server changes.
> We need to define a stable api that can be used here.
> lets outline what api is actually needed and then subjiras for the specifics.
> For me it looks like server lookup needs a few things:
> 0. know exact version of server
> 1. know the file structure of a certain server
> 2. get dir or directories that contain jar that is the "runtime"
> My guess is that #2 might just be sufficient for source code lookup.
> Any comments ? 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira