[jbosstools-issues] [JBoss JIRA] (JBIDE-15317) LiveReload script injection corrupted html encoding

[Xavier Coulon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12797584#comment-12797584 ] 

Xavier Coulon edited comment on JBIDE-15317 at 9/12/13 3:12 AM:
----------------------------------------------------------------

Hello [~tangtheone],

first, thanks for your feedback and thanks for reporting the invalid content-length header value that I was returning in my code !

I pushed an update of the PR in which the return content uses the same charset as the one given in the request, or it falls back the "Default Charset" that can be configured at the server level. Thus, if you set "UTF-8" at the LiveReload server level (this is the default value anyway), you should have the expected content in response.

Let me know if this works for you.

Thanks.
Best regards,


                
      was (Author: xcoulon):
    Hello [~tangtheone],

first, thanks for your feedback and thanks for reporting the invalid content-length header value that I returning in my code !

I pushed an update of the PR in which the return content uses the same charset as the one given in the request, or it falls back the "Default Charset" that can be configured at the server level. Thus, if you set "UTF-8" at the LiveReload server level (this is the default value anyway), you should have the expected content in response.

Let me know if this works for you.

Thanks.
Best regards,


                  
> LiveReload script injection corrupted html encoding
> ---------------------------------------------------
>
>                 Key: JBIDE-15317
>                 URL: https://issues.jboss.org/browse/JBIDE-15317
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: livereload
>    Affects Versions: 4.1.0.Final
>            Reporter: Pei-Tang Huang
>            Assignee: Xavier Coulon
>            Priority: Critical
>              Labels: encoding, livereload
>             Fix For: 4.1.1.Alpha1, 4.2.0.Alpha1
>
>         Attachments: chinese.html
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> LiveReload script injection dissmisses the encoding of the original HTML content, my page contains CJK character in UTF-8 all became "?" character.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira