[jbosstools-issues] [JBoss JIRA] (JBTIS-171) Don't override other connectors in discovery.xml

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBTIS-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805201#comment-12805201 ] 

Nick Boldt commented on JBTIS-171:
----------------------------------

I think the problem is that I don't define "generating a new pair of composite*.xml files" as "a rebuild of JBDSIS", but rather a simple exercise that anyone could do.

Here's a sample of those 2 files:

http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta2/compositeArtifacts.xml
http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta2/compositeContent.xml

Also, if you wanted to test JBDSIS 7.0.0.Beta2 against JBDS 7.1.0.Alpha1, with your solution, would require 4 runtime parameters:

-Djboss.is-discovery.directory.url=http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta2/devstudio-integration-stack-directory.xml
-Djboss.is-discovery.site.url=http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta2/
-Djboss.discovery.directory.url=http://www.qa.jboss.com/binaries/RHDS/discovery/development/7.1.0.Alpha1/devstudio-integration-stack-directory.xml
-Djboss.discovery.site.url=http://www.qa.jboss.com/binaries/RHDS/discovery/development/7.1.0.Alpha1/

*BUT WAIT!* 

How does Central know to look in TWO different directory.xml files? 

Answer: It doesn't. It can't. It can only see one jboss.discovery.directory.url - either the default one set in the Examples plugin in JBT, or the value set in jbdevstudio.ini (or eclipse.ini), or the value you pass in via commandline override.

So, to support the notion of feeding in content from more than one place (ie., the Core and IS plugins), we have a generated/merged JBDSIS directory.xml file, which references both JBDS IS and JBDS Core content in a single xml file:

{code:title=http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta2/devstudio-integration-stack-directory.xml}
<entry url="https://devstudio.jboss.com/updates/7.0/discovery/com.jboss.jbds.central.discovery_7.0.0.Final-v20130819-0921-B276.jar" permitCategories="true"/>
<entry url="com.jboss.jbds.central.discovery.integration-stack_7.0.0.Beta2.CI-2013-09-14_08-04-55-B34-v20130914-0804-B34.jar" permitCategories="true"/>
{code}

So how do you tell JBDS 7.0 to read the combination of [JBDS 7.1 discovery plugin + JBDS IS 7.0 discovery plugin]? You generate a new .xml file which lists these:

{code}
<entry url="http://www.qa.jboss.com/binaries/RHDS/discovery/development/7.1.0.Alpha1/plugins/com.jboss.jbds.central.discovery_7.0.0.Final-v20130909-1001-B291.jar" permitCategories="true"/>
<entry url="com.jboss.jbds.central.discovery.integration-stack_7.0.0.Beta2.CI-2013-09-14_08-04-55-B34-v20130914-0804-B34.jar" permitCategories="true"/>
{code}

And how do you generate that? Well, you run this build:

https://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/JBDSIS-aggregate-disc/

If you have a better way that "just regenerate the XML files", I'm happy to hear it, but I don't think your solution is a complete one.
                
> Don't override other connectors in discovery.xml
> ------------------------------------------------
>
>                 Key: JBTIS-171
>                 URL: https://issues.jboss.org/browse/JBTIS-171
>             Project: JBoss Tools Integration Stack
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: distribution
>            Reporter: Max Rydahl Andersen
>            Assignee: Paul Leacu
>
> Currently this is in discovery plugin:
>  siteUrl="$\{jboss.discovery.site.url:https://devstudio.jboss.com/updates/7.0-development/central/integration-stack/}"
>       
> And instructions to test it says:
> -vmargs -Djboss.discovery.directory.url=http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta1/devstudio-integration-stack-directory.xml -Djboss.discovery.site.url=http://www.qa.jboss.com/binaries/RHDS/discovery/integration/integration-stack/7.0.0.Beta1
> This is all great but it disables all other connectors in JBDS/eclipse thus it makes it hard to get together.
> I suggest you use your own specific site url instead, something like:
>  siteUrl="$\{jboss.discovery.integration-stack.site.url:https://devstudio.jboss.com/updates/7.0-development/central/integration-stack/}"
> Then the base connectors will still work.
> We might even consider using recursive properties to allow for a global override, this would need changing in both IS And core discovery.xml to the tune of:
> in core: siteUrl="$\{jboss.global.discovery.site.url,jboss.discovery.site.url:https://devstudio.jboss.com/updates/7.0-development/central/core}"
> in stack:
> siteUrl="$\{jboss.global.discovery.site.url,jboss.discovery.integration-stack.site.url:https://devstudio.jboss.com/updates/7.0-development/central/integration-stack/}"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira