[jbosstools-issues] [JBoss JIRA] (JBIDE-15435) "installed plugins" detection seems fishy in project examples / central

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805787#comment-12805787 ] 

Snjezana Peco commented on JBIDE-15435:
---------------------------------------

{quote}
So Project fixes check for the presence of only one plugin/bundle id : https://github.com/jbosstools/jbosstools-central/blob/master/examples/plugins/org.jboss.tools.project.examples/src/org/jboss/tools/project/examples/fixes/PluginFix.java#L33
{quote}

The plugin fix will check all the plugins you defined in a project example xml. The GWT project example declares only one plugin, but you can add as much fixes as you want.

{quote}
I think the problem is that there is some broken or non-understood semantics in how the examples define and test the existence of the required plugins.
{quote}

The plugin fix checks a plugin(s). A connector can check some IU (plugins or features). In this case connector checks features.

{quote}
Why is both plugin and connector id necessary ? shouldn't connector id be sufficient ?
{quote}

When we added the plugin fix, we didn't have either connector or central.

{quote}
Right now connector id seem to only be used when deciding what to install.
{quote}

Correct.

{quote}
how does a project example list multiple plugins ? 
{quote}
 
You can declare plugin fixes in a project xml file as much as you want.
 
{quote}
and can they use features instead so they don't break if plugins gets added/remvoed ?
{quote}
 
They can't now, but that can be added.

Currently, Project Examples and the Software/Update page aren't compatible.
If you think that Project Examples and the Software/Update page should be compatible, we have to add a connectorId or feature (IU) fix.

                
> "installed plugins" detection seems fishy in project examples / central
> -----------------------------------------------------------------------
>
>                 Key: JBIDE-15435
>                 URL: https://issues.jboss.org/browse/JBIDE-15435
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central, discovery, project-examples
>    Affects Versions: 4.1.0.Final
>            Reporter: Fred Bricon
>            Assignee: Fred Bricon
>             Fix For: 4.1.1.Alpha2
>
>
> Following JBDS-2753, [~maxandersen] says he installed the JBoss GWT connector, which dragged the GPE plugins.
> Some functionality seem missing according to Max (which ones?). In the JBoss Central 'software updates' page, the GWT/GPE connector is shown as missing. In the GWT example wizard, the feature appears as installed. One of the 2 is wrong, obviously.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira