[jbosstools-issues] [JBoss JIRA] (JBIDE-15575) Creation of foundation.ui to hold TaskWizard framework

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-15575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12808105#comment-12808105 ] 

Rob Stryker commented on JBIDE-15575:
-------------------------------------

The two methods in the page which catch the exception and return false are:  isPageComplete(),  and canFlipToNextPage()

For both of these methods, the method it's calling is fragment.isComplete().   In a WizardFragment,  isComplete() should be a very very simple method which only returns true or false.  No complicated logic should ever be done in fragment.isComplete().  If the fragment wishes to update its fragment completion status, it should use  protected void setComplete(boolean complete) {}. 

So,  in 99.9% of the cases, isComplete() should never throw an exception.  The exception catching is there only in case an extender decided to do complicated logic in the isComplete() method, which they shouldn't be doing. You'll note that WizardFragment.isComplete() does not throw any exceptions at all.  

In either event, I added tracing to the two methods so that if a developer is wishing to debug their wizard fragment, they can enable tracing on the foundation.ui plugin. 

I do not think its appropriate for the framework to throw an exception here or to log an error in the error log, and I believe tracing is the appropriate solution. For that reason, I am marking the JIRA as resolved again. 
                
> Creation of foundation.ui to hold TaskWizard framework
> ------------------------------------------------------
>
>                 Key: JBIDE-15575
>                 URL: https://issues.jboss.org/browse/JBIDE-15575
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common/jst/core
>    Affects Versions: 4.2.0.Alpha1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Alpha1
>
>
> Creation of a foundation.ui is required for a few reasons:
> 1)  runtimes should not depend on common. A foundation.ui is needed for that
> 2)  Hold taskwizard, a framework from wtp internals which is very very useful and many have expressed interest in using. Runtimes will be using this framework very soon and others will convert in the future. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira