[jbosstools-issues] [JBoss JIRA] (JBIDE-16976) OpenShift import: Error dialog after importing application without SSH key on PaaS is not enough descriptive

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12958363#comment-12958363 ] 

Andre Dietisheim commented on JBIDE-16976:
------------------------------------------

This is what EGit is throwing. When reporting the error I add the reason "an exception occurred when creating the local git repository" and put the exception that's thrown to the error details. I guess that if I'd unpack what EGit throws I'd unveil a nested Auth error. Not sure if we really want to unpack exceptions thrown by EGit since the nesting is not API. We could - as a general rule - "unpack" TargetInvocationErrors and display the exception within it.
                
> OpenShift import: Error dialog after importing application without SSH key on PaaS is not enough descriptive
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-16976
>                 URL: https://issues.jboss.org/browse/JBIDE-16976
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.2.0.Beta1
>            Reporter: Marián Labuda
>            Priority: Minor
>         Attachments: error_dialog.png
>
>
> When creating application and following import (git clone after creation process is completed) in case of no SSH key/not added into preferences dialog there is a error dialog with description, that something went wrong during git clone (respectively creating local git repo) and exception thrown. 
> !error_dialog.png!
> It would be nice to have in the dialog, that problem is caused by missing SSH key or at least remove InvocationTargetException from error message - it is useless for user.
> Error log stack trace 
> {code}
> java.lang.reflect.InvocationTargetException
> 	at org.eclipse.egit.core.op.CloneOperation.run(CloneOperation.java:176)
> 	at org.jboss.tools.openshift.egit.core.EGitUtils.cloneRepository(EGitUtils.java:270)
> 	at org.jboss.tools.openshift.express.internal.ui.wizard.application.importoperation.AbstractImportApplicationOperation.cloneRepository(AbstractImportApplicationOperation.java:169)
> 	at org.jboss.tools.openshift.express.internal.ui.wizard.application.importoperation.ImportNewProject.execute(ImportNewProject.java:77)
> 	at org.jboss.tools.openshift.express.internal.ui.wizard.application.OpenShiftApplicationWizardModel.importProject(OpenShiftApplicationWizardModel.java:103)
> 	at org.jboss.tools.openshift.express.internal.ui.wizard.application.OpenShiftApplicationWizard$ImportJob.runInWorkspace(OpenShiftApplicationWizard.java:353)
> 	at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:38)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:53)
> Caused by: java.lang.IllegalStateException: Preference node "null" has been removed.
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferences.checkRemoved(SecurePreferences.java:354)
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferences.nodeExists(SecurePreferences.java:100)
> 	at org.eclipse.equinox.internal.security.storage.SecurePreferencesWrapper.nodeExists(SecurePreferencesWrapper.java:94)
> 	at org.eclipse.egit.core.securestorage.EGitSecureStore.clearCredentials(EGitSecureStore.java:108)
> 	at org.eclipse.egit.ui.internal.credentials.EGitCredentialsProvider.reset(EGitCredentialsProvider.java:142)
> 	at org.eclipse.jgit.transport.JschConfigSessionFactory.getSession(JschConfigSessionFactory.java:125)
> 	at org.eclipse.jgit.transport.SshTransport.getSession(SshTransport.java:121)
> 	at org.eclipse.jgit.transport.TransportGitSsh$SshFetchConnection.<init>(TransportGitSsh.java:248)
> 	at org.eclipse.jgit.transport.TransportGitSsh.openFetch(TransportGitSsh.java:147)
> 	at org.eclipse.jgit.transport.FetchProcess.executeImp(FetchProcess.java:136)
> 	at org.eclipse.jgit.transport.FetchProcess.execute(FetchProcess.java:122)
> 	at org.eclipse.jgit.transport.Transport.fetch(Transport.java:1111)
> 	at org.eclipse.jgit.api.FetchCommand.call(FetchCommand.java:130)
> 	at org.eclipse.jgit.api.CloneCommand.fetch(CloneCommand.java:178)
> 	at org.eclipse.jgit.api.CloneCommand.call(CloneCommand.java:125)
> 	at org.eclipse.egit.core.op.CloneOperation.run(CloneOperation.java:156)
> 	... 7 more
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira