[jbosstools-issues] [JBoss JIRA] (JBIDE-17052) Adding repository to settings.xml located in folder which does not exist fails

[Fred Bricon (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-17052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Bricon resolved JBIDE-17052.
---------------------------------

    Resolution: Done


Fixed in master. Egit f*ed up line endings though : https://github.com/jbosstools/jbosstools-central/commit/456b6c1f02936d9bb101311331a39289415e037e#diff-37e7ef0bb7fe6c8f7dc768cf580c65a7R1158 

Fix just consists in creating settings.xml parent hierarchy if necessary (4 LOC)
                
> Adding repository to settings.xml located in folder which does not exist fails
> ------------------------------------------------------------------------------
>
>                 Key: JBIDE-17052
>                 URL: https://issues.jboss.org/browse/JBIDE-17052
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 4.2.0.Beta1
>            Reporter: Rastislav Wagner
>            Assignee: Fred Bricon
>            Priority: Minor
>             Fix For: 4.2.0.Beta2
>
>         Attachments: repo.png
>
>
> Stacktrace
> {code}
> java.io.FileNotFoundException: /files/RedHat/tmp/tmpx/settings1.xml (No such file or directory)
> 	at java.io.FileOutputStream.open(Native Method)
> 	at java.io.FileOutputStream.<init>(FileOutputStream.java:206)
> 	at java.io.FileOutputStream.<init>(FileOutputStream.java:156)
> 	at org.jboss.tools.maven.ui.wizard.ConfigureMavenRepositoriesWizardPage.finishPage(ConfigureMavenRepositoriesWizardPage.java:1158)
> 	at org.jboss.tools.maven.ui.wizard.ConfigureMavenRepositoriesWizard.performFinish(ConfigureMavenRepositoriesWizard.java:67)
> 	at org.eclipse.jface.wizard.WizardDialog.finishPressed(WizardDialog.java:853)
> 	at org.eclipse.jface.wizard.WizardDialog.buttonPressed(WizardDialog.java:438)
> 	at org.eclipse.jface.dialogs.Dialog$2.widgetSelected(Dialog.java:636)
> 	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4425)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3773)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3393)
> 	at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
> 	at org.eclipse.jface.window.Window.open(Window.java:808)
> 	at org.jboss.tools.maven.ui.preferences.ConfiguratorPreferencePage$2.widgetSelected(ConfiguratorPreferencePage.java:192)
> 	at org.eclipse.swt.widgets.TypedListener.handleEvent(TypedListener.java:248)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4425)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3773)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3393)
> 	at org.eclipse.jface.window.Window.runEventLoop(Window.java:832)
> 	at org.eclipse.jface.window.Window.open(Window.java:808)
> 	at org.eclipse.ui.internal.dialogs.WorkbenchPreferenceDialog.open(WorkbenchPreferenceDialog.java:215)
> 	at org.eclipse.ui.internal.OpenPreferencesAction.run(OpenPreferencesAction.java:65)
> 	at org.eclipse.jface.action.Action.runWithEvent(Action.java:519)
> 	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:595)
> 	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:511)
> 	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:420)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4425)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1388)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:3773)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3393)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1122)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1006)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:147)
> 	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:630)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:574)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:125)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:133)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:103)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:378)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:232)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:483)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1462)
> 	at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira