[jbosstools-issues] [JBoss JIRA] (JBIDE-17919) Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type

[Jeff Cantrill (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989963#comment-12989963 ] 

Jeff Cantrill commented on JBIDE-17919:
---------------------------------------

Validated the bug exists based on the revised repo steps.  One thing I did notice after trying to save a second time is the file name is now (bug?):

{{/home/jeff(1).cantrill/git/diy/diy-full.tar.gz}}
 which is some variation of when the file already exists and the second copy is represented USUALLY like:
{{/home/jeff.cantrill/git/diy/diy-full(1).tar.gz}}.  
I'm not sure if this is the tooling code creating this file name or not; that requires additional investigation.

At [~mlabuda] suggestion, I investigated how rhc behaves and found that it does not care if the file exists or not.  It overwrites the file or creates a new one.  If you do not provide the '--filename' switch, it creates a file of <project_name>.tar.gz.  Subsequent calls overwrite and do not add a numerical index and/or timestamp.

[~adietish] can you comment on what we should do to resolve to make it conform with intended design:
# Reload the original file name instead of the 'duplicate' file name (e.g. /home/user.name/file-full.tar.gz instead of /home/user(1).name/file-full-tar.gz or  /home/user.name/file-full(1).tar.gz
# Allow the user to edit the file name by typing it in (currently not able)
# Remove 'full/deployment' from the filename to be consistent with rhc
# Add a index or timestamp to the filename to make it unique from the previous snapeshot

> Snapshot wizard: snapshot file name is not refreshed upon changes between full and deployment type
> --------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-17919
>                 URL: https://issues.jboss.org/browse/JBIDE-17919
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Marián Labuda
>            Assignee: Jeff Cantrill
>              Labels: snapshot_wizard
>             Fix For: 4.2.0.CR1
>
>
> When trying to create a new snapshot of FULL or DEPLOYMENT type after creating a snapshot earlier, there is no change of file name for the snapshot. It's still the same file name as it was for the snapshot created right before.
> I think there was intention to let user overwrite previously created snapshot. But this brings complications because of snapshot type. We should not override FULL snapshot with DEPLOYMENT snapshot. I think also, that there should not be overriding at all, but it should be distinguished as it is (after workaround) by number of snapshot.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)