[jbosstools-issues] [JBoss JIRA] (JBIDE-18862) when removing a module from AS runtime marker files are not removed automatically

Darryl Miles (JIRA) issues at jboss.org
Tue Dec 2 07:16:39 EST 2014


    [ https://issues.jboss.org/browse/JBIDE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024378#comment-13024378 ] 

Darryl Miles edited comment on JBIDE-18862 at 12/2/14 7:15 AM:
---------------------------------------------------------------

The AS does emit a info/warning in server.log when an unexpected marker file exists.

So if *.dodeploy is the only marker file that JBIDE creates.

Then please take this bug to ensure that:

* When REMOVING a module from runtime the *.dodeploy file is also deleted by Eclipse.  [This is a bug right now]

* Before ADDING a module to runtime, but before writing the EAR (or other module implementation data), ensure the *.dodeploy file is deleted by Eclipse.  You delete it to prevent cross-over from a failed REMOVE and to ensure Eclipse doesn't process it.  [Difficult to see/test as publishing can be too quick]

* Before ADDING a module to runtime, but before writing the EAR (or other module imlementation data), ensure the target toplevel name/file is deleted.  This would be "rm -rf  ear-0.0.1-SNAPSHOT.ear.ear\"  (as an exploded directory)  or maybe "rm -f foobar-0.0.1-SNAPSHOT.ear" (as a file).  This is to ensure a CLEAN is done before anything is written.  Maybe server tooling already does this?   [This appears to be the case in a quick test with exploded directory deployment, but would be nice to have it confirmed by someone understanding the Eclipse/JBIDE code]

* (only) After ADDING a module to runtime, then you can re-create the *.dodeploy at the point when everything is publish ok.   [Sure I can see a file there each time I expect it]


was (Author: dlmiles):
The AS does emit a info/warning in server.log when an unexpected marker file exists.

So if *.dodeploy is the only marker file that JBIDE creates.

Then please take this bug to ensure that:

* When REMOVING a module from runtime the *.dodeploy file is also deleted by Eclipse.

* Before ADDING a module to runtime, but before writing the EAR (or other module implementation data), ensure the *.dodeploy file is deleted by Eclipse.  You delete it to prevent cross-over from a failed REMOVE and to ensure Eclipse doesn't process it.
* Before ADDING a module to runtime, but before writing the EAR (or other module imlementation data), ensure the target toplevel name/file is deleted.  This would be "rm -rf  ear-0.0.1-SNAPSHOT.ear.ear\"  (as an exploded directory)  or maybe "rm -f foobar-0.0.1-SNAPSHOT.ear" (as a file).  This is to ensure a CLEAN is done before anything is written.  Maybe server tooling already does this?

* (only) After ADDING a module to runtime, then you can re-create the *.dodeploy at the point when everything is publish ok.

> when removing a module from AS runtime marker files are not removed automatically
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-18862
>                 URL: https://issues.jboss.org/browse/JBIDE-18862
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: server
>         Environment: Windiws7 64bit, JDK 8u25
>            Reporter: Darryl Miles
>            Priority: Minor
>
> module removal does not delete the various marker files relating to it:
> *.undeployed
> *.dodeploy
> The same should be true when ADDING a module, it should clean out any marker files.
> Setup an deploy-inhibiting marker file to ensure it won't try to deploy it before the *.ear is full written.
> Write out the*.ear file.
> Then adjust the marker files as necessary to reflect the intended state of the module (if it should be started then remove the inhibiting marker file in the previous step).



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)


More information about the jbosstools-issues mailing list