[jbosstools-issues] [JBoss JIRA] (JBIDE-18363) BrowserSim/CordovaSim skins for iPhone 6 and 6+

[Ilya Buziuk (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13025068#comment-13025068 ] 

Ilya Buziuk commented on JBIDE-18363:
-------------------------------------

[~akazakov], actually I did 3 commits deliberately:
1 commit - is about adding IOS 8 navigation bar (issue JBIDE-18771)
2 commit - implementing IPhone 6 *skin* (horizontal / vertical layout)
3 commit - adding IPhone 6 / 6+ *devices* by updating preferences

I do like the approach when commit has logical completeness and prefer not to create 1 commit with giant changes, cause it make it difficult to review history  and find bugs. WDYT?

> BrowserSim/CordovaSim skins for iPhone 6 and 6+
> -----------------------------------------------
>
>                 Key: JBIDE-18363
>                 URL: https://issues.jboss.org/browse/JBIDE-18363
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: browsersim, cordovasim
>    Affects Versions: 4.2.0.Final
>            Reporter: Alexey Kazakov
>            Assignee: Ilya Buziuk
>              Labels: new_and_noteworthy, respin-a
>             Fix For: 4.2.1.CR1, 4.3.0.Alpha1
>
>         Attachments: iphones.png
>
>




--
This message was sent by Atlassian JIRA
(v6.3.8#6338)