[jbosstools-issues] [JBoss JIRA] (JBIDE-18862) when removing a module from AS runtime marker files are not removed automatically

[Darryl Miles (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026791#comment-13026791 ] 

Darryl Miles commented on JBIDE-18862:
--------------------------------------

We're talking about adding and removing JavaEE _MODULES_ here.  So a full or incremental publish aspect should be irrelevant.  The actions performed by Eclipse is the same, because there is no such thing as "removing a whole JavaEE module incrementally", there is only the concept of "remove the whole JavaEE module".

The deletion of the toplevel directory (or file, in the case of deploying as JAR) is not related to the concept of a "Full Publish" vs "Incremental Publish".

When adding a module, the Eclipse AS driver should ensure the toplevel target is deleted, and it is not trying to publish over the top of a failed removal (possibly due to file locking).  If the toplevel directory is not assured of being not-existing before the start of publish a warning should really be issued to the user, whom can "continue anyway", "abort the module add action".   This is what my third point talks of.



> when removing a module from AS runtime marker files are not removed automatically
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-18862
>                 URL: https://issues.jboss.org/browse/JBIDE-18862
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: server
>         Environment: Windiws7 64bit, JDK 8u25
>            Reporter: Darryl Miles
>            Priority: Minor
>             Fix For: 4.2.2.Final, 4.3.0.Alpha1
>
>
> module removal does not delete the various marker files relating to it:
> *.undeployed
> *.dodeploy
> The same should be true when ADDING a module, it should clean out any marker files.
> Setup an deploy-inhibiting marker file to ensure it won't try to deploy it before the *.ear is full written.
> Write out the*.ear file.
> Then adjust the marker files as necessary to reflect the intended state of the module (if it should be started then remove the inhibiting marker file in the previous step).



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)