[jbosstools-issues] [JBoss JIRA] (JBIDE-18862) when removing a module from AS runtime marker files are not removed automatically

[Darryl Miles (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026795#comment-13026795 ] 

Darryl Miles commented on JBIDE-18862:
--------------------------------------

In your conflict sequence of events it is not clear if you are talking about the same JavaEE module in point 2 and point 3.

This comes back to my long standing explanation of how publishing should be happening (from maybe 5 years ago with Max and JBIDE folk).

Step 1) Eclipse instructs the AS to inhibit all deployment operations!
Step 2) The AS positively acknowledges this instruction from Step 1 above (in the case of a deployment is in progress at the AS side, it would not need to be aborted, it would continue until success or failure, at that point the AS would return the positive acknowledgement that all AS deployment operations have been temporary inhibited at Eclipse's request).
Step 3) Eclipse does publish operation (modifies files/dirs).
Step 4) Eclipse instructs the AS the remove the inhibit of all deployment operations.  Ideally this might be done with remoting/EJBclient/HTTPwebsocket so if the socket connection breaks/closes that also removes the inhibiter at the AS side.
Step 5) This also allows the AS to immediately deploy what is sees.  No waiting around a few seconds for something to notice.  Although I've not seen this problem in a while.

You could fine grain it further, by only inhibiting a single module.

I don't know how many times I have explained the above before, but those writing the code implement things as they think best :)  without working through all the corner cases (you are only now seeing).

FWIW it is possible to know if the AS is deploying because there will be a *.isdeploying marker present!  :)  If this is present during remove (or add?) JavaEE module Eclipse IDE could wait, maybe upto 10 seconds by default before offering to the user "cancel operation" or "continue waiting another 10seconds".  But the progress monitor should clearly state "waiting for server AS to remove isdeploying marker" and it should be cancellable.

> when removing a module from AS runtime marker files are not removed automatically
> ---------------------------------------------------------------------------------
>
>                 Key: JBIDE-18862
>                 URL: https://issues.jboss.org/browse/JBIDE-18862
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: server
>         Environment: Windiws7 64bit, JDK 8u25
>            Reporter: Darryl Miles
>            Priority: Minor
>             Fix For: 4.2.2.Final, 4.3.0.Alpha1
>
>
> module removal does not delete the various marker files relating to it:
> *.undeployed
> *.dodeploy
> The same should be true when ADDING a module, it should clean out any marker files.
> Setup an deploy-inhibiting marker file to ensure it won't try to deploy it before the *.ear is full written.
> Write out the*.ear file.
> Then adjust the marker files as necessary to reflect the intended state of the module (if it should be started then remove the inhibiting marker file in the previous step).



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)