[jbosstools-issues] [JBoss JIRA] (JBIDE-14960) BrowserSim/CordovaSim: externalize messages

[Vlado Pakan (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-14960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12940910#comment-12940910 ] 

Vlado Pakan commented on JBIDE-14960:
-------------------------------------

It's inconsistent in PR #151 comment //$NON-NLS-1$ and in PR #179 these comments are removed and  @SuppressWarnings("nls") is added. It should be consistent?

If we just one get rid of warnings we should use @SuppressWarnings("nls") but I suggest to leave  //$NON-NLS-1$ in code for future when we will need to externalize messages. These comments are/was already there so why not use them in future?

If we really just want to remove all  //$NON-NLS-1$ comments we should change title of this Jira because it's not about messages externalization
                
> BrowserSim/CordovaSim: externalize messages
> -------------------------------------------
>
>                 Key: JBIDE-14960
>                 URL: https://issues.jboss.org/browse/JBIDE-14960
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: browsersim
>         Environment: All messages should be externalized
>            Reporter: Yahor Radtsevich
>            Assignee: Vlado Pakan
>             Fix For: 4.2.0.Alpha1
>
>
> Messa

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira