[jbosstools-issues] [JBoss JIRA] (JBIDE-15256) Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
Nick Boldt (JIRA)
issues at jboss.org
Thu Feb 20 11:49:48 EST 2014
[ https://issues.jboss.org/browse/JBIDE-15256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12946537#comment-12946537 ]
Nick Boldt edited comment on JBIDE-15256 at 2/20/14 11:48 AM:
--------------------------------------------------------------
Parent pom should already be built w/ that change:
https://github.com/jbosstools/jbosstools-build/commit/638658345fce166ad495608ca66a483002c70e81 (6mo ago)
If not, https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-build.parent_master/ will check github for changes every 5 mins and builds will publish to nexus automatically.
was (Author: nickboldt):
Parent pom should already be built w/ that change:
https://github.com/jbosstools/jbosstools-build/commit/638658345fce166ad495608ca66a483002c70e81 (6mo ago)
If not, https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-build.parent_master/ will check github for changes every 5 mins.
> Include tycho-source-feature-plugin and tycho-p2-plugin into parent/pom.xml/build/pluginManagement
> --------------------------------------------------------------------------------------------------
>
> Key: JBIDE-15256
> URL: https://issues.jboss.org/browse/JBIDE-15256
> Project: Tools (JBoss Tools)
> Issue Type: Enhancement
> Components: build
> Affects Versions: 4.2.0.Alpha1
> Reporter: Denis Golovin
> Assignee: Denis Golovin
> Fix For: 4.2.0.Beta1
>
>
> Currently every feature's pom.xml includes the same code, which is code-duplication issue.
> {code}
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> <version>${tychoExtrasVersion}</version>
> <executions>
> <execution>
> <id>source-feature</id>
> <phase>package</phase>
> <goals>
> <goal>source-feature</goal>
> </goals>
> </execution>
> </executions>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> <version>${tychoVersion}</version>
> <executions>
> <execution>
> <id>attached-p2-metadata</id>
> <phase>package</phase>
> <goals>
> <goal>p2-metadata</goal>
> </goals>
> </execution>
> </executions>
> </plugin>{code}
> It should be included into pluginManagement section of parent/pom.xml instead and that would reduce code duplication to
> {code}<plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>{code}
> in every feture's pom.xml file.
> More over code above could be moved to to features/pom.xml as
> {code}<build>
> <plugins>
> <plugin>
> <groupId>org.eclipse.tycho.extras</groupId>
> <artifactId>tycho-source-feature-plugin</artifactId>
> </plugin>
> <plugin>
> <groupId>org.eclipse.tycho</groupId>
> <artifactId>tycho-p2-plugin</artifactId>
> </plugin>
> </plugins>
> </build>{code}
> that would let keep pom.xml for every feature even cleaner.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
More information about the jbosstools-issues
mailing list